Merge dev-talesam into main - #35
Merged
Merged
Conversation
The displaymanager module was in every profile's exec sequence but had no configuration, and with no displaymanagers list in either globalstorage or a displaymanager.conf, Calamares falls back to ["sysconfig"] - a SUSE-only path - so the job enabled nothing. What covered for it was services.conf, which enables sddm by name: KDE installs booted, and a GNOME or XFCE install ended up with no display-manager.service at all, stopping at a text login on first boot. Nothing here regressed to cause it. gdm and lightdm were never in any services.conf and this file never existed; the gap was simply never reached while every image installed through the biglinux profile, where sddm is what KDE wants anyway. The module enables the first display manager on the list that is installed in the target, so one list serves each edition - sddm on KDE, gdm on GNOME, lightdm on Cinnamon and XFCE - and the same file suits all three profiles. services.conf keeps its own sddm entry for now: dropping it would change what currently makes KDE work, and that is worth testing separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request created by GitRepo.