Repository navigation
Fix plot bmtr - #248
Merged
Merged
Fix plot bmtr#248
Conversation
…tor PR
Accepted contributor changes: BMTR (birds/km) default label, crop_bbox
parameter, zero-cells → NA with na.value=transparent, white as first
gradient color, sort() on transitions, length(transitions) > 1 operator
precedence fix, theme_void() with explicit white backgrounds.
Fixed/rejected:
- Add droplevels() after subset filter so facet_wrap drops excluded
transitions rather than showing empty panels
- Fix character subset validation: names(transitions) (always NULL) →
transitions; fix typo in error message
- Revert exists("suppress_specific_warnings") guard — function is always
present as a package internal
- Remove hardcoded annotation_borders("state") — US-only, maps not in
DESCRIPTION
- Use crs(bf) in coord_sf calls instead of sf::st_crs(bf$geom$crs)
- Strip developer-note inline comments
Add @PARAM crop_bbox to roxygen. Add test verifying subset produces
no empty facets for both numeric and character subset forms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bugs with plot_bmtr(), add ability to crop, and change plot aesthetics slightly.