Repository navigation
chore: raise minimum PHP version to 7.4 - #22
Merged
Merged
Conversation
Update composer.json, the Rector PHP version and set, and CLAUDE.md. The composer compat script already targets 7.4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises the minimum PHP version from 7.2 to 7.4.
Changes
composer.json:phprequirement is now>=7.4.rector.php:PhpVersion::PHP_74andSetList::PHP_74. The typed-property skips stay.CLAUDE.md: updated the stated minimum version and syntax rules.composer compatalready targets7.4-, so it needs no change. Nosrc/code changes.Release
Release this as a minor version (1.3.0), not a patch. Sites on PHP 7.2 or 7.3 will stop receiving updates of this library.
Testing
src/composer compatcomposer rectordry-runThe Pest suite was not run on PHP 7.4 because Pest 2 needs PHP 8.1+, and the CI matrix starts at 8.1.
Do not apply Rector's suggestion for
src/Helpers.php: it removes$current = $valuefromsetNestedElement(), and that line is what writes the value through the reference.🤖 Generated with Claude Code