Repository navigation
[pull] develop from smartcontractkit:develop - #630
Merged
Merged
Conversation
* Bump version and update CHANGELOG for v2.66.0 (cherry picked from commit 16456b3) * Add minor changeset for next release cycle --------- Co-authored-by: chainlink-releases-bot <svc-chainlink-releases@smartcontract.com>
* lint(core,root): fix violations
* core logger cleanup
* Better TestScripts
* Better TestScripts
* linting clenaups
* Address PR review feedback on lint sweep
- webauthn.go: revert RPOrigins migration back to deprecated RPOrigin
field. The real fix (preserving construction-time validation when
RPOrigin is empty) is going into its own layer above this one.
- audit_logger.go: revert ForwardToUrl/Headers error handling to the
original silent-disable behavior; the stricter fail-on-bad-config
change is its own behavior change, split into the layer above.
- audit_logger.go: fix lost caller-skip on audit log lines. The
core/logger -> chainlink-common/pkg/logger migration swapped
`logger.Helper(1)` for `logger.Sugared(lggr)`, but Sugared() only
applies the skip to its own sugar-only methods (AssumptionViolation,
Critical, etc.), not to the base Errorw/Debugw/etc calls this file
actually uses. Use `logger.Helper(lggr, 1)` instead, which applies
the skip to every method.
- cltest.go: revert bodyclose helpers from t.Cleanup(cleanup) back to
defer cleanup(); no behavior benefit, and it held HTTP response
bodies open for the lifetime of the test instead of the call.
- cache.go: revert doBulkUpsert's slices.Collect back to the
preallocated slices.AppendSeq version; this PR's whole point is
prealloc fixes, this hunk removed one.
- types.go: revert isValidLocalURI's net.LookupPort back to the plain
stdlib call; wrapping it in net.DefaultResolver.LookupPort(context.
Background(), ...) added an import and a no-op context for zero
behavior change (no context available in this function anyway).
- handler_test.go: restore the require.Len(t, result.Signatures, 1)
assertions dropped when result.Signature was added. handler.go still
populates the deprecated Signatures field for legacy readers; the
test should still cover it.
- audit_types.go: add missing ChainRpcNodeAdded/ChainRpcNodeDeleted
back-compat aliases, matching the pattern already used for the
ConfigSqlLogging* rename in this same file.
- mutation.go, log_controller.go: update the two remaining callers of
the old ConfigSqlLogging* names to the renamed ConfigSQLLogging*
identifiers (these were the only reason the alias was load-bearing
rather than purely for external consumers).
- auth.go: add the missing "Deprecated:" doc marker on ErrorAuthFailed
for consistency with the other back-compat aliases in this PR.
- trigger_publisher.go: rename ctx2 -> unregisterCtx.
- outgoing_connector_handler(_test).go: revert `var x = T{...}` back to
`x := T{...}`, and restore two blank lines between functions that
were dropped incidentally.
- audit_logger_test.go: rename a local `logger` variable that shadowed
the package import.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
* use errors
* fix nil errors
* proper MFA error
* more complete scriptTB
* better testscripts shim
---------
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
…23792) * Fail fast on bad audit config; migrate webauthn to RPOrigins Two deliberate behavior changes split out of the lint-sweep layer below, so each gets its own review and isolated blast radius. - audit_logger.go: NewAuditLogger now returns an error when config.ForwardToUrl() or config.Headers() fail, instead of silently falling back to a disabled no-op logger. A malformed AUDIT_LOGS_* config is a real misconfiguration; failing node startup surfaces it immediately instead of letting audit logging silently go dark. - webauthn.go: migrate off the deprecated go-webauthn Config.RPOrigin field to Config.RPOrigins, via a small rpOrigins() helper. An empty configured RPOrigin still produces a nil/empty RPOrigins slice, so webauthn.New's own "must provide at least one value to the 'RPOrigins' field" validation still fires at construction time, exactly as the deprecated single-value field did. Without this guard, an empty RPOrigin would instead pass construction as RPOrigins: [""] and only fail later, per-request, during origin comparison in login/registration - turning a loud startup error into a confusing runtime one. Tests added: - TestNewAuditLogger_ConfigErrors covers both new error returns. - TestBeginWebAuthnRegistration_EmptyRPOrigin locks in the empty-origin construction-time error. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * log audit issue --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )