Repository navigation
[pull] develop from smartcontractkit:develop - #633
Merged
Merged
Conversation
…es (#23818) Bump stale apt curl pin to 8.5.0-2ubuntu10.15 The exact pin 'curl=8.5.0-2ubuntu10.13' hard-depends on libcurl4t64 (= 8.5.0-2ubuntu10.13), which the Ubuntu archives no longer serve (only 8.5.0-2ubuntu10.15 remains), so the image build fails with: The following packages have unmet dependencies: curl : Depends: libcurl4t64 (= 8.5.0-2ubuntu10.13) but 8.5.0-2ubuntu10.15 is to be installed E: Unable to correct problems, you have held broken packages. Same failure class as #23649 (stale gnupg pin on release/2.62.3): exact apt pins age out whenever Ubuntu ships a security update. ports.ubuntu.com (arm64) pruned the old libcurl4t64 first, so amd64 CI can stay green while arm64 builds of the image are broken locally.
* chore: define WorkflowEngine interface and assert Engine implements it * refactor: extract baseEngine from Engine * chore: ErrShardDeniedNotOwner/ErrShardDeniedOrchestrator were moved to the shard failover manager * feat: implement execution only engine * refactor: move Put and handleAllTriggerEvents methods to engine.go as these are not shared across engine and executionEngine * chore: remove outdated comment * chore: parameterize engine name * fix: enforce ObservedAt * chore: remove initSubscriptions, rename coordinatedEngine and add Subscriber interface * test: make shardDenial test excercise the engine's subscription path * chore: rename CRE to Tenant * chore: make Subscriber part of the WorkflowEngine interface + documentation improv * chore: reordering base_engine * chore: unexport errObservedAtMissing * chore: reorder useWorkflowLimit * test: improve TestEngine_ShardDenial test * test: happy path for coordinatedEngine * chore: make coordinatedEngine type unexported * chore: make engine unexported * test: assert on actual counters instead of waiting on a channel * chore: base *baseEngine as a named field instead of embedding * fix: revert setEngine signature change * chore: docstring improvements * test: promote and reuse newTestEngine * test: improve test by using counters instead of ch * chore: remove redundant interface check * refactor: uses newTestEngine in ShardDenial test * chore: rename initServiceEngine --------- Co-authored-by: Michael Street <5597260+MStreet3@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )