Repository navigation
[pull] develop from smartcontractkit:develop - #638
Merged
Merged
Conversation
A PR that adds a new CRE settings flag (new cresettings key + the code that reads it) AND an e2e test that enables it via ApplyCRESettings fails mixed-env: the override is validated only in the test process against the PR schema and delivered to every node, but the baseline nodes silently ignore the unknown key and have no reader for it. The 2 PR nodes act on the flag, the 2 baseline nodes cannot, so the DON diverges 2-vs-2 and trips the non-determinism gate (consensus stall + log-marker scan) even though the PR is correct. Add t_helpers.IsMixedEnvTopology() and t_helpers.SkipIfMixedEnv(t, reason), keyed strictly on TOPOLOGY_NAME, so such a test can opt out of mixed-env while still running in full under the normal single-image suite. The helper carries a strong warning to use it only when a 2-vs-2 split is unavoidable and expected. Convert the existing DON Time skip to the new helper and route nonDeterminismCheckEnabled() through IsMixedEnvTopology() for one source of truth. Document the caveat and the warning in cresettings-override-README.md and mixed-env.md. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )