Drop embedded js-ipfs (ipfs-core); keep HTTP Kubo API - #1
Open
IshmaelRogers wants to merge 2 commits into
Open
IshmaelRogers wants to merge 2 commits into
IshmaelRogers wants to merge 2 commits into
Conversation
The upstream already had an HTTP mode against the Kubo RPC API (api/v0) via got; only the embedded-node path used ipfs-core (EOL). Remove that path and _coreMode, keeping the HTTP behavior and therefore byte-identical CIDs (same add options, same cid<->hash math). Endpoint from FORGE_IPFS_API / IPFS_API. Drop ipfs-core and the now-unused sleep-promise; pin engines node>=20.
Modern Kubo returns 500 ("removed, use 'ipfs dag' or 'ipfs files'") for
object/stat. files/stat on /ipfs/<cid> returns the same CumulativeSize.
Verified against a live kubo daemon: full API smoke (add/cat/pin/size +
cid<->hash inverse + deterministic CID) passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the EOL embedded js-ipfs (
ipfs-core) path, keeping the HTTP-to-Kubo mode the library already had. CIDs stay byte-identical (sameaddoptions + cid/hash math). Endpoint viaFORGE_IPFS_API/IPFS_API;engines.node >=20. This modernizes the shared IPFS wrapper the whole DigiAssetX family (digiasset-encoder/decoder/lookup/input) depends on, so a singleoverridesentry removes js-ipfs from the entire tree.