Conversation
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
The bare-multisig error prints a literal "{}" because its .format() call
is missing. The wpkh branch reports "More than one pubkey in pkh
descriptor", copied from the pkh branch.
Add unit tests for both error paths: a wpkh() with two pubkeys, and a
top-level bare multisig with four pubkeys whose message must report the
count.
fametrano
force-pushed
the
descriptor-fix-error-messages
branch
from
September 9, 2026 14:10
3c51513 to
d8a39c4
Compare
fametrano
changed the title
Contributor
Author
|
Added two regression tests covering both fixed messages, mirroring the equivalent electrum change (spesmilo/electrum#10947). Both fail on the pre-fix messages and pass after the fix; |
Contributor
Author
|
The electrum twin, spesmilo/electrum#10947, was merged on 2026-09-09 (87121026, by ecdsa): same two messages, same two tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two error messages in
hwilib/descriptor.py, now fixed and covered by tests:{}because its.format(len(pubkeys))call was missing — it now reports the actual count (e.g. "Cannot have 4 pubkeys in bare multisig: only at most 3 pubkeys");wpkhbranch reported "More than one pubkey in pkh descriptor", copied from thepkhbranch — now "wpkh".test/test_descriptor.pyadds two regression tests that exercise these two paths throughparse_descriptor:test_wpkh_rejects_multiple_pubkeys— asserts thewpkhmessage nameswpkh;test_bare_multisig_too_many_pubkeys_reports_count— asserts the count is interpolated.Both fail against the pre-fix messages and pass after the fix. This mirrors the equivalent electrum change ((spesmilo/electrum#10947, merged 2026-09-09)).