Conversation
_get_func_expr located the closing parenthesis with rindex but never checked that it was the final character, so any content following it was silently discarded and a descriptor such as pkh(<key>)garbage parsed as pkh(<key>). Require the closing parenthesis to be the last character and raise ValueError naming the trailing text otherwise, matching Bitcoin Core's rejection of trailing bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_get_func_exprfinds the closing parenthesis withrindex, but nothing checks that it is the final character, so trailing text after a descriptor's outer)is silently dropped:pkh(<key>)garbageparses aspkh(<key>).Bitcoin Core rejects trailing bytes —
Funcinsrc/script/parsing.cpprequires the closing parenthesis to be the span's last character. This makes_get_func_exprdo the same, raisingValueErrorand naming the trailing text.The checksum is stripped before parsing and
_get_func_expronly ever receives a standalonefunc(...)expression, so no valid descriptor is affected; the existing tests pass unchanged, and a regression test covers a flat and a nested case.The equivalent fix for Electrum, which shares this descriptor code, is spesmilo/electrum#10948.