BIP375: validate PSBT_OUT_SP_V0_LABEL length - #2286
Open
wangjingshuiku wants to merge 1 commit into
Open
wangjingshuiku wants to merge 1 commit into
wangjingshuiku wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the BIP-375 reference validator to enforce the serialized length of PSBT_OUT_SP_V0_LABEL.
BIP-375 defines the field value as a 32-bit little-endian unsigned integer, so PSBT_OUT_SP_V0_LABEL must contain exactly 4 bytes. Previously, the validator only checked that PSBT_OUT_SP_V0_LABEL requires PSBT_OUT_SP_V0_INFO, allowing malformed values such as a one-byte label when valid SP_V0_INFO was present.