bips 89/114/441: add missing Footnotes and references tag - #2289
Merged
Merged
Conversation
These three BIPs use <ref> footnotes but never place a <references/> tag, so GitHub's mediawiki renderer drops the footnote text entirely and the [n] superscripts link to anchors that do not exist. Add a Footnotes section (BIP 89, BIP 441) or the tag under the existing References section (BIP 114) so the notes are rendered.
jonatack
reviewed
Sep 14, 2026
jonatack
left a comment
jonatack
left a comment
Member
There was a problem hiding this comment.
ACK good fixes, modulo one question below
Match the convention used in BIP89 and BIP441: place <references/> under a dedicated Footnotes section rather than directly under References, per jonatack's review comment on PR bitcoin#2289.
Contributor
Author
|
Fixed in 50777eb: moved |
jonatack
changed the title
Member
|
Thank you for updating. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BIP 89, BIP 114 and BIP 441 use
<ref>…</ref>footnotes but none of them contains a<references/>tag. GitHub's mediawiki renderer only emits the footnote bodies where that tag appears, so on the rendered pages the footnote text is missing and the[n]superscripts point at#cite_note-nanchors that do not exist (e.g. BIP 89's notes onlift_x, auxiliary randomness andblindsecnonce; BIP 441's five rationale notes).This adds a
Footnotessection with<references/>to BIP 89 and BIP 441 (before Acknowledgements/Thanks, matching BIP 340), and puts the tag under BIP 114's existingReferencessection.Rendering-only change, no text of the BIPs is modified, so no changelog entries were added; happy to add one for BIP 89 if preferred.