bip-10: open the example TxDP block with <pre>, not </pre> - #2290
Merged
Merged
Conversation
Line 57 uses a closing </pre> where the opening tag was intended, so the example TxDP that follows (up to the real </pre> on line 90) is rendered as prose instead of a preformatted block.
murchandamus
left a comment
murchandamus
left a comment
Member
There was a problem hiding this comment.
The proposed change is obviously correct, but just FYI, your claim that it renders incorrectly is not. I can’t explain why it works, but clearly you didn’t look at it yourself…
murchandamus
added
the
Fixups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bip-0010.mediawikiline 57 has a closing</pre>where the opening tag of the example TxDP block was meant. As a result the whole example (-----BEGIN-TRANSACTION-3fX59xPj---…through line 90) renders as unformatted prose on GitHub, with the leading whitespace and line structure lost. Changing it to<pre>balances the tags (3 open / 3 close) and restores the block.