bip-433: fix heading levels, stray '<', typos, add Copyright section - #2291
Merged
Merged
Conversation
- Specification was a level-3 heading and therefore rendered as a subsection of Motivation; Backward Compatibility, Implementation and Related Work were one level too deep as well. - Drop the stray '<' in front of the testnet address tb1pfees9rn5nz. - 'typea' -> 'type', 'ineherent' -> 'inherent'. - Add the Copyright section required by BIP 3, matching the BSD-3-Clause License header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editorial fixes to BIP 433 (P2A), no change to the specification itself:
===Specification===was a level-3 heading, so on the rendered page (and in the TOC) Specification appears as a subsection of Motivation;Implementation/Related Workwere level 4 andBackward Compatibilitywas level 4 instead of being a top-level section. Reset them to==Specification==/===Implementation===/===Related Work===/==Backward Compatibility==.<in<code><tb1pfees9rn5nz</code>(the address itself is correct:bech32m("tb", 1, 0x4e73)=tb1pfees9rn5nz).Licenseheader.