Repository navigation
feat(cli): add dotenv support, env var template, and bitcoind setup docs - #342
Closed
Olorunshogo wants to merge 1 commit into
Closed
Olorunshogo wants to merge 1 commit into
Olorunshogo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Notes to the reviewers
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes:
PR summary
Summary
dotenvyand load.envat startup, beforeenv_logger::init(), so every#[arg(env = "...")]value insrc/can be set via a file instead of shell exports. A missing.envstays silent; a malformed one now logs awarn!instead of failing silently..env.exampledocumenting every environment variable the CLI reads, grouped by command (global options, descriptors, backends, proxy, key management, transaction building, PSBT ops,compile, Payjoin, logging)..gitignore: the entry was.env/, a directory-only pattern that never matched the.envfile itself. Changed to.env.README.md:bitcoind/bitcoin-cliprerequisite for therpcfeature and theJustfileworkflow, with an install snippet and a checksum-verification note.cp .env.example .envinto both the install instructions and the regtest walkthrough.$(just address)vs${just address}footgun with an explicit note.Files changed
Cargo.toml/Carg5"src/main.rs.envon startup, warn on parse failure.env.example.gitignore.env/→.envREADME.mdTest plan
cp .env.example .env, setNETWORK, confirm it applies without a CLI flag.env, confirm awarnlog appears and the app still startsgit check-ignore .envreports it as ignored