You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ci: add bdk_demo analysis and flutter tests to windows-smoke job - #148
Hi @reez, In jobs like build-and-test, android-smoke, and ios-smoke i see we we run subosito/flutter-action@v2 followed by dart-lang/setup-dart@v1. Do we need to setup dart when we setup flutter? wouldn't that lead to version conflict especially since we set Dart SDK to version 3.10.0, or is there a reason for that?
Hi @reez, In jobs like build-and-test, android-smoke, and ios-smoke i see we we run subosito/flutter-action@v2 followed by dart-lang/setup-dart@v1. Do we need to setup dart when we setup flutter? wouldn't that lead to version conflict especially since we set Dart SDK to version 3.10.0, or is there a reason for that?
I don’t think they conflict cuz flutter always uses its own bundled Dart, and setup-dart only changes which SDK plain dart commands use, which is 3.10.0 here. In build-and-test that tests the root package on its minimum Dart. In ios-smoke and android-smoke it’s redundant and can be removed in a followup. Dropping it on Windows here is fine. Thanks!
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add bdk_demo analysis and flutter tests to windows-smoke job to follow up on the updates from #147