[thunderbiscuit]

This PR updates the bdk_wallet dependency to 3.2.0, and most importantly picks up the patch in bdk_chain 0.23.4 that fixes bitcoindevkit/bdk#2057 (see also PR bitcoindevkit/bdk#2182). This is a long-standing bug that was independently reported to us by 2 different users.

Fixes #1088.

Description

Notes to the reviewers

Documentation

• bdk_wallet
• bitcoin
• uniffi
• Other:

Changelog

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing
• I've added exactly one changelog:* label
• I've linked the relevant upstream docs or specs above

New Features:

• I've added tests for the new feature
• I've added docs for the new feature

Bugfixes:

• This pull request breaks the existing API
• I've added tests to reproduce the issue which are now passing
• I'm linking the issue being fixed by this PR

[reez]

Concept ACK just ping when fixes in for ci failures

[thunderbiscuit]

@reez I added the #[allow(deprecated)] on the methods that are now deprecated. We unfortunately don't have a way to throw those warnings down to the downstream languages layer, so for them it will just look like a clean break when those disappear in a future breaking release.

[reez]

@reez I added the #[allow(deprecated)] on the methods that are now deprecated. We unfortunately don't have a way to throw those warnings down to the downstream languages layer, so for them it will just look like a clean break when those disappear in a future breaking release.

Should we open up a tracking issue for this for 4.0?

ACK ec61c0a

[thunderbiscuit]

Should we open up a tracking issue for this for 4.0?

Good idea. Done in #1143

(I guess if we move to bdk_wallet 4.0 we won't have a choice because those methods will probably not be there anymore, but they could also decide to keep a few and we to not actually offer them or something corner case or whatever, so yeah good to keep tracking it).

[reez]

Should we open up a tracking issue for this for 4.0?

Good idea. Done in #1143

(I guess if we move to bdk_wallet 4.0 we won't have a choice because those methods will probably not be there anymore, but they could also decide to keep a few and we to not actually offer them or something corner case or whatever, so yeah good to keep tracking it).

Great thanks!