build(silentpayments): raise MSRV to 1.85.0 - #71
Merged
Merged
Conversation
kkdao
force-pushed
the
fix/msrv-core-error
branch
from
August 21, 2026 21:36
8d9765f to
a8523ae
Compare
kkdao
marked this pull request as draft
August 21, 2026 21:48
kkdao
marked this pull request as ready for review
August 21, 2026 21:56
kkdao
changed the title
nymius
requested changes
Aug 25, 2026
kkdao
changed the title
kkdao
force-pushed
the
fix/msrv-core-error
branch
from
August 26, 2026 03:50
bd9c721 to
659d2fe
Compare
bdk_sp declared Rust 1.63, but the crate uses core::error::Error, which requires Rust 1.81 or newer. Raise the declared MSRV to 1.85.0 to match current BDK packages, and drop the stale CONTRIBUTING.md claim that 1.63.0 is enforced by CI.
kkdao
force-pushed
the
fix/msrv-core-error
branch
from
August 26, 2026 03:56
01636bb to
3298491
Compare
nymius
approved these changes
Aug 26, 2026
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #69
bdk_spdeclares Rust 1.63, but the crate usescore::error::Error, which requires Rust 1.81 or newer.This raises the declared MSRV to Rust 1.85.0, matching current BDK packages, and removes the stale
CONTRIBUTING.mdclaim that Rust 1.63 is enforced by CI.The implementation and workflow remain unchanged.
Verification
The full workspace checks, Clippy, tests, and documentation tests pass. The
bdk_splibrary also builds with exact Rust 1.85.0 using all features and the committed lockfile.Changelog notice
Changed:
bdk_spnow requires Rust 1.85.0.