ci(mutants): build the baseline with --all-features - #74
Merged
Merged
Conversation
8 tasks
nymius
approved these changes
Aug 31, 2026
nymius
requested changes
Aug 31, 2026
nymius
left a comment
nymius
left a comment
Collaborator
There was a problem hiding this comment.
I need you to sign the commit to merge.
The incremental mutants lane has been failing at the unmutated baseline, so no mutants are ever tested. Args after `--` are handed to the test phase only, so the baseline build ran with default features. `bdk_sp` gates serde behind an optional feature while its tests derive Deserialize, which leaves the test targets uncompilable without it and fails the build before mutation starts. Pass the feature through `--cargo-arg` instead, which applies to every cargo invocation including the build. It also has to come out of the trailing args: `--cargo-arg` already adds it to the test command, and cargo rejects `--all-features` given twice. Verified against the diff from bitcoindevkit#70, which previously died at the baseline: 7 mutants found, 6 caught, 1 unviable, none missed.
kkdao
force-pushed
the
fix/mutants-baseline-features
branch
from
August 31, 2026 21:33
2182bf2 to
14e6cbe
Compare
nymius
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Incremental mutants testlane is currently dead: it fails at the unmutated baseline on every PR, so no mutants are ever tested. The last run on master, 783c63c, is red for the same reason.Args after
--are handed to the test phase only, so the baseline build runs with default features.bdk_spgatesserdebehind an optional feature while its test scaffolding derivesDeserialize, so the test targets do not compile without it and the build fails before mutation starts. Reproduces on a clean master worktree withcargo check -p bdk_sp --tests.Passing the feature through
--cargo-argfixes it, since that applies to every cargo invocation including the build. It also has to come out of the trailing args:--cargo-argalready adds it to the test command, and cargo rejects--all-featurestwice.Verified locally against the diff from #70, which previously died at the baseline:
Unrelated, noted while here and left alone: this workflow has
on: push: branches: [main]while the default branch ismaster, so that trigger never fires. The job is gated on `github.event_name == 'pull_request' anyway, so it changes nothing today.