Repository navigation
Dispose browser context in CloseTarget & fix graceful shutdown - #351
Merged
Merged
Conversation
Patch addresses several issues with the "graceful shutdown". - Don't use `disposeOnDetach` anymore, may fix #349 - ... instead dispose browser context explicitly in CloseTarget, may fix #350 - Fix broken shutdown handling in Channel: weirdly missing the trap, like this is it can't have ever worker, but I'm sure it worked at some point - Fix broken shutdown handling in SessionPool: We must actually do handle the shutdown now (as we have no faith in `disposeOnDetach` anymore), hence we must capture the channel pid in the init to avoid calling the supervisor during shutdown
maltoe
force-pushed
the
fix/dispose-browser-context-in-close-target
branch
from
September 28, 2026 07:07
d786ff9 to
6159570
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch addresses several issues with the "graceful shutdown".
disposeOnDetachanymore, may fix Regression of #56: Chrome OS process survives pooled and on-demand shutdown on macOS (chromic_pdf 1.17.1) #349disposeOnDetachanymore), hence we must capture the channel pid in the init to avoid calling the supervisor during shutdown