Skip to content

Coverage is measured and reported but never enforced — no thresholds configured #656

Description

@Jamie-BitFlight

What is missing

The Vitest coverage block in vite.config.ts configures a provider, an output directory, reporters and an include path, and stops there:

coverage: {
  provider: "v8",
  reportsDirectory: "./out",
  reporter: ["text", "json-summary", "json"],
  include: ["src/"],
},

There is no thresholds key. npm run coverage runs in CI (test.yml) and the result is posted to the PR by vitest-coverage-report-action, which is configured continue-on-error: true.

Why this matters for validating work in this repository

Coverage is currently a number on a PR comment that nothing acts on. A change can remove tests, or add substantial untested code, and the only signal is a percentage moving in a comment that a reviewer has to notice and interpret.

For agent work in particular this is the difference between a gate and a suggestion — an agent reading CI status sees green regardless of what happened to coverage.

Impact

There is no floor. The reported figures at the time of writing are around 83% statements and 78% branches; nothing prevents the next change from lowering either.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions