chore(pre-commit): pin node to 24.16.0 in default_language_version - #3
Merged
Merged
Conversation
24.16.0 is the Node that Volta provides at /Users/jamienelson/.volta/bin/node, and is the version proven to work where prek's bundled Node 26.8.1 could not start at all on macOS 12.7.6: dyld: Symbol not found: (__ZNSt3__122__libcpp_verbose_abortEPKcz) that libc++ predates the symbol. `node: system` is not sufficient. Measured with forced-fresh prek env hashes: `system` stops prek DOWNLOADING a toolchain but does not stop it PREFERRING one already downloaded. Against the poisoned cache, `system` failed with the identical dyld error while `24.16.0` passed by resolving to Volta. The broken toolchain has since been deleted, so hooks work today, but that fix lives in one machine's cache and does not travel to a new machine, a cleared cache, or a CI runner. The pin does.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
node: 24.16.0underdefault_language_versionin.pre-commit-config.yaml.Why this version
24.16.0 is the Node that Volta provides at
/Users/jamienelson/.volta/bin/node, and is the version proven to work where prek's bundled Node 26.8.1 could not start at all on macOS 12.7.6:That libc++ predates the symbol.
Why a pin and not
systemMeasured with forced-fresh prek env hashes:
node: systemstops prek downloading a toolchain but does not stop it preferring one already downloaded. Against the poisoned cache,systemfailed with the identical dyld error while24.16.0passed by resolving to Volta.The broken toolchain has since been deleted, so hooks work today — but that fix lives in one machine's cache and does not travel to a new machine, a cleared cache, or a CI runner. The pin does.
Verification
/Users/jamienelson/.volta/tools/image/node/24.16.0/bin/node(v24.16.0), measured with alanguage: nodeprobe hook.prek run --all-filesgate run before and after the change; identical result.Cost
CI reads this file too, so CI runners will install Node 24.16.0 instead of whatever they previously resolved.
🤖 Generated with Claude Code
https://claude.ai/code/session_01QJeBLNA9ybmQvv5REMDkrc