fix(cli): render help at a fixed width regardless of terminal size - #312
Jamie-BitFlight wants to merge 3 commits into
Conversation
`check --help` wrapped and truncated the platform choices line in a
narrow terminal (40 columns cut "--platform" and the choices list).
Follow the daily-releases scripts' Typer pattern: set
context_settings={"terminal_width": 800} and rich_markup_mode=None on
the root app so Click renders plain, unwrapped help. Rich help sizes
itself from TERMINAL_WIDTH/COLUMNS and ignores terminal_width, so both
settings are needed. Tighten the platform help test to assert the full
choices line under COLUMNS=40.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K5rAHJfvZyEEaUQghV7hCQ
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📊 Test Coverage ReportCoverage: 88.74% 📥 Coverage XML available as artifact: |
Complete the Typer app pattern used by the daily-releases, receiving-pr-reviews and create-merge-request-changelog skill scripts in claude_skills: pretty_exceptions_enable=False alongside the fixed terminal_width and rich_markup_mode=None, so tracebacks are plain and not wrapped to the terminal width either. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K5rAHJfvZyEEaUQghV7hCQ
|
Separately, verified from Generated by Claude Code |
Benchmark Results🔴 Regression detected — threshold: 30% scan-clean
scan-violations
fix-violations
cpu
import
Updated 2026-09-30 14:32 UTC |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
bb9001c to
9459353
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 78e2df29b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
State why terminal_width is fixed, how Click uses it (typer/_click/formatting.py), and that 800 matches the Typer apps in claude_skills, per the repository's no-invented-constraints rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K5rAHJfvZyEEaUQghV7hCQ
Follow-up to #300.
Summary
skilllint check --helpwrapped and truncated its output in narrow terminals. At 40 columns Rich rendered--platfo…and splitPlatform adapter. Choices: …across lines. The skill tells agents to read accepted platform names from that line, so a wrapped or truncated line loses information.This applies the Typer app pattern already used by the skill scripts in
claude_skills:.agents/skills/daily-releases/scripts/cleanup_stale_releases.py.agents/skills/receiving-pr-reviews/scripts/pr_review_threads.py.claude/skills/create-merge-request-changelog/scripts/format_mr_description.pyThe root Typer app in
packages/skilllint/plugin_validator.pynow sets:TERMINAL_WIDTH/COLUMNSand ignores Click'sterminal_width.rich_markup_mode=Noneswitches help to Click's plain formatter, which honoursterminal_width.pretty_exceptions_enable=Falsekeeps tracebacks plain instead of Rich panels wrapped to the terminal width.The platform help test now invokes
check --helpunderCOLUMNS=40and asserts the wholePlatform adapter. Choices: …line, replacing the per-choice workaround.Verification
check --helpatCOLUMNS=40and80prints--platform <str> Platform adapter. Choices: claude-code, codex, cursoron one line.check,rule,rules,docsand everydocssubcommand--helprender with no raw Rich markup (grep for[bold]-style tags: 0 hits).main'splugin_validator.pyand passes with the change.uv run prek run --all-filespasses;uv run pytest: 1904 passed, 14 skipped, with and withoutFORCE_COLOR=1.Behaviour change
--helpoutput changes from Rich panels to Click's plain layout, and uncaught exceptions print plain tracebacks. Command output (rules,rule,checkreports) still uses Rich.🤖 Generated with Claude Code
https://claude.ai/code/session_01K5rAHJfvZyEEaUQghV7hCQ