PM-40295: bug: Add MP Policy checks on vault unlock

[david-livefront]

🎟️ Tracking

PM-40295

📔 Objective

This PR moves all the MasterPassword Policy logic into a new class and adds the policy check on vault unlock as well as login.

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR extracts master password policy logic out of AuthRepositoryImpl into a new PasswordPolicyManager/PasswordPolicyManagerImpl, wires it through DI, and adds the policy check on vault unlock (VaultLockManagerImpl.processMasterPassword) in addition to login. AuthRepository now delegates to PasswordPolicyManager, so existing callers of passwordPolicies, passwordResetReason, getPasswordStrength, and validatePasswordAgainstPolicies remain source-compatible. Tests were moved alongside the new manager and unlock/logout paths gained corresponding storePasswordToCheck/removePasswordToCheck verifications. The extraction is clean and the validation logic is preserved verbatim.

Code Review Details

• ❓ : Cached plaintext password is no longer cleared on user switch (only on lock/logout), lengthening the in-memory retention window for a backgrounded account
  • app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/policy/PasswordPolicyManagerImpl.kt:101

[david-livefront]

@vvolkgang Once the KeystoreManager is ready, I would like to encrypt this data.

[codecov]

Codecov Report

❌ Patch coverage is 52.63158% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.93%. Comparing base (c6f7a47) to head (bd2e4c2).

Files with missing lines	Patch %	Lines
...atform/manager/policy/PasswordPolicyManagerImpl.kt	39.43%	25 Missing and 18 partials ⚠️
...twarden/data/vault/manager/VaultLockManagerImpl.kt	89.47%	0 Missing and 2 partials ⚠️

❗ There is a different number of reports uploaded between BASE (c6f7a47) and HEAD (bd2e4c2). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (c6f7a47)	HEAD (bd2e4c2)
app-ui-platform	1	0

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #7165       +/-   ##
===========================================
- Coverage   86.19%   69.93%   -16.26%     
===========================================
  Files         884      990      +106     
  Lines       64674    66712     +2038     
  Branches     9681     9709       +28     
===========================================
- Hits        55745    46656     -9089     
- Misses       5456    17035    +11579     
+ Partials     3473     3021      -452     

Flag	Coverage Δ
app-data	17.68% <51.57%> (-0.08%)	⬇️
app-ui-auth-tools	18.78% <1.05%> (+<0.01%)	⬆️
app-ui-platform	?
app-ui-vault	27.35% <0.00%> (-0.01%)	⬇️
authenticator	6.10% <0.00%> (-0.01%)	⬇️
lib-core-network-bridge	4.01% <0.00%> (-0.02%)	⬇️
lib-data-ui	1.15% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.