Repository navigation
fix(release): push the release tag explicitly - #8
Merged
Merged
Conversation
- add releasePushArgs and push the new tag by name after --follow-tags - --follow-tags only pushes annotated tags, so the lightweight release tag (the repo's convention) was never published - cover the refspecs with a pure spec test, matching releaseStagePaths Verification: npm run verify (762 vitest + 20 release tests, skill gates) passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the release flow so the git tag is actually published.
scripts/release.mjspushed withgit push --follow-tags, but--follow-tagsonly pushes annotated tags. This repository's release tags are lightweight (v1.2.1,v1.3.0,v1.3.1are all commit objects), so release tags were silently never pushed. This was observed on thev1.4.0release (chore(release): v1.4.0,e3f6c8f): npm publishedfluentui-skill@1.4.0, but no tag appeared on the remote.Change
releasePushArgs(version)that returns the orderedgitargument lists: the branch push (--follow-tags) plus an explicitgit push origin vX.Y.Z.gitPush(version)runs those refspecs;version/releasepass the new version,publishomits it (no new tag).releaseStagePaths()contract.Verification
npm run verify— PASS: 762 Vitest + 20 release tests, plus typecheck, version parity, and the skill gates.Note
v1.4.0was tagged manually to complete that release; this change makes future releases push the tag themselves.