Skip to content

fix(voice): default speech output to Siri - #241

Merged
johnmatthewtennant merged 1 commit into
mainfrom
jtennant/default-siri-tts
Aug 27, 2026
Merged

fix(voice): default speech output to Siri#241
johnmatthewtennant merged 1 commit into
mainfrom
jtennant/default-siri-tts

Conversation

@johnmatthewtennant

Copy link
Copy Markdown
Contributor

Category: fix
User Impact: New macOS voice conversations now use Siri speech output by default while preserving any voice output the user explicitly selected.

Problem: Berd temporarily defaulted to Pocket TTS on macOS to avoid garbled Siri playback. The Siri audio path has since been normalized, so that workaround no longer reflects the preferred native voice experience.

Solution: Restore Siri as the macOS default while keeping Pocket as the default on other platforms and preserving saved Pocket or Siri selections.

File changes

src/features/voice-conversation/lib/voiceOutputPreference.ts
Selects Siri as the default output backend on macOS and Pocket elsewhere.

src/features/voice-conversation/lib/voiceOutputPreference.test.ts
Updates the macOS default assertions while retaining coverage for non-macOS fallback and explicit saved preferences.

@johnmatthewtennant
johnmatthewtennant requested a review from a team August 27, 2026 14:51

@morgmart morgmart left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Automated code review

Reviewed the exact three-dot comparison e89beaf...1671cd5 with the project code-review and wes-review lenses. The change restores Siri as the macOS default while preserving explicit persisted choices and the non-macOS Pocket fallback. Static inspection found no publishable issues. Supplied GitHub evidence is structurally valid but currently shows no completed check result (combined status pending), so required checks still govern merge readiness. Recommendation: APPROVE.

Deterministic publication result: 0 blocking and 0 non-blocking finding(s) publishable; 0 duplicate(s) suppressed.

Pending checks: 1 check(s) are not complete.

This approval reflects the completed code review only; merge readiness remains governed by the repository's required checks.

@johnmatthewtennant
johnmatthewtennant merged commit 91ec049 into main Aug 27, 2026
14 of 15 checks passed
@johnmatthewtennant
johnmatthewtennant deleted the jtennant/default-siri-tts branch August 27, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants