Skip to content

Keep feedback surveys visible after remount #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
comp615 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −7
Open

Keep feedback surveys visible after remount #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/features/chat/response-feedback/sessionFeedbackSurveyState.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,15 @@ describe("sessionFeedbackSurveyState", () => {
expect(claimCooldown).toHaveBeenCalledTimes(2);
});

it("blocks remount presentation while the appeared owner can respond", async () => {
it("keeps an appeared survey presentable across virtualized remounts", async () => {
const survey = await claim("appeared-once");
expect(survey).not.toBeNull();
if (!survey) throw new Error("expected survey to be selected");
markSessionFeedbackSurveyAppeared("appeared-once", survey.appearanceId);

expect(
isSessionFeedbackSurveyPresentable("appeared-once", survey.appearanceId),
).toBe(false);
).toBe(true);
recordSessionFeedbackSurveyResponse(
"appeared-once",
survey.appearanceId,
Expand Down
6 changes: 1 addition & 5 deletions src/features/chat/response-feedback/sessionFeedbackSurveyState.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,11 +198,7 @@ export function isSessionFeedbackSurveyPresentable(
appearanceId: string,
): boolean {
const record = readSessionRecord(sessionId);
return (
record?.active?.appearanceId === appearanceId &&
!record.appeared &&
!record.response
);
return record?.active?.appearanceId === appearanceId && !record.response;
}

export function markSessionFeedbackSurveyAppeared(
Expand Down
Loading