Skip to content

Add email lookup for app access - #14

Closed
nathan-thillairajah wants to merge 2 commits into
mainfrom
nthillairajah/app-email-lookup
Closed

nathan-thillairajah wants to merge 2 commits into
mainfrom
nthillairajah/app-email-lookup

Conversation

@nathan-thillairajah

@nathan-thillairajah nathan-thillairajah commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Add bl apps people resolve APP_ID --email alice@example.net --role viewer --json so app owners can look up a workspace member before assigning access. Use --environment to select the same environment as the grant.

The command returns the control plane's person, status and next action. It makes no grant: the owner confirms the person and uses the exact returned subject in a separate access update. Lookup must be enabled by the deployment, and email changes become visible after the recipient's trusted sign-in refreshes the saved profile.

A process test checks the authenticated request, response and absence of a grant. The CLI test and lint suites passed.

Review order (activation follows separately):

  1. Kgoose: identity lookup and validation.
  2. Compose: owner API and grant checks.
  3. CLI (this PR): email lookup command.
  4. Design notes: contract and activation requirements.

@nathan-thillairajah
nathan-thillairajah requested a review from a team as a code owner October 8, 2026 17:26
@scottcrawford03

Copy link
Copy Markdown
Contributor

🤖 Scrawford on it — reviewing this PR now.

@scottcrawford03

Copy link
Copy Markdown
Contributor

🤖 Automated Expert Review

Summary

Adds an owner-facing command to resolve a workspace member by email before a separate access grant. The request matches the control-plane contract, and no material correctness issues were found.


Findings

No material findings.


Checklist

Check Status Notes
🔒 Security ✅ Reuses authenticated requests and approved-host validation; lookup makes no grant.
🏗️ Reliability ✅ Environment forwarding and response handling match the API contract.
🚀 Deployment safety ✅ Additive OSS command; availability remains controlled by the server.
🧪 Tests ✅ Head-commit CI passed, including both new tests, linting, and Docker acceptance.
💰 Cost / blast radius ✅ One lookup request; no access-policy mutation.

Verdict: APPROVE

The CLI logic is sound and verified by passing CI; no material blockers were identified.


🤖 Review by Scrawford agent · not a substitute for human review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants