Repository navigation
BOT-2523: make apps private at creation and switch their audience - #39
Merged
Merged
Conversation
nathan-thillairajah
force-pushed
the
markS/bot-2475-community-cli
branch
from
October 29, 2026 17:40
32b391b to
39980ed
Compare
nathan-thillairajah
force-pushed
the
markS/bot-2523-private-cli
branch
from
October 29, 2026 17:41
9fcff47 to
2379241
Compare
nathan-thillairajah
force-pushed
the
markS/bot-2475-community-cli
branch
from
October 29, 2026 17:48
39980ed to
d4b3950
Compare
nathan-thillairajah
force-pushed
the
markS/bot-2523-private-cli
branch
from
October 29, 2026 17:49
2379241 to
6bb77e1
Compare
`bl apps create --private` makes the reserved app private before initialization, so a private app is never visible. If that step fails, create stops before initializing and tells the caller not to deploy. `bl apps visibility APP_ID workspace|private` changes only the base audience through PUT /visibility, keeping viewers, publishers and community grants. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Retrying doesn't help with every failure, so the error now also points at `bl apps visibility APP_ID private`. Adds a test that a retried create reconciles the reservation and then makes it private. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nathan-thillairajah
force-pushed
the
markS/bot-2523-private-cli
branch
from
October 29, 2026 18:06
6bb77e1 to
bafcbc7
Compare
nathan-thillairajah
changed the base branch from
markS/bot-2475-community-cli
to
main
October 29, 2026 18:06
kalvinnchau
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of BOT-2523. Stacked on #38, and uses the visibility-only API from squareup/blockplat-compose#500.
What changes
bl apps create --privatemakes the app private right after it's reserved and before it's initialized, so a private app is never visible. Any deploy is a separate command that runs later.bl apps visibility APP_ID workspace|privateswitches an existing app between "everyone in your workspace" and "only people I add". It sends only{"visibility": ...}toPUT /v1/agent/apps/{app_id}/visibility, so viewers, publishers and community grants are kept, and it prints the resulting audience. The internal valuesorganization/restrictedaren't accepted here.Tests
--privatecalls plan, reserve, visibility, initialize, in that order.--privatemakes no visibility call.visibilitysends only the visibility for both audiences, and rejects a mismatched response.visibilityrejects internal or unknown audiences before auth or network.visibilityand--privateshow up in help and--describe-commands.just testandjust lintpass.Ordering
This needs compose#500 deployed before it's useful. #500 is stacked on #496. Merge this after #38.
🤖 Generated with Claude Code