Skip to content

refactor(agents): type screens against an agent type view - #1732

Closed
loganj wants to merge 1 commit into
agent-host-remote-handlesfrom
agent-host-type-view
Closed

loganj wants to merge 1 commit into
agent-host-remote-handlesfrom
agent-host-type-view

Conversation

@loganj

@loganj loganj commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

🤖

Summary

Details

  • AgentTypeView in features/agents/service.ts holds:
    • identity (key, pluginId, revision, id), title and description;
    • what the type shows (icon, Peek, Create, CreateModel, tabs) and its config functions (AgentTypeConfig);
    • provider (readiness store, check, attention action and its dialog parts);
    • the models and usage calls;
    • remote, kept only as presence (screens only test whether a type is hosted);
    • sessionControls with only scope and subscribe. The state and actions already go through the service's sessionState and session.
  • The Agents page, its create, settings, browse, defaults and provider dialogs, AgentTabs, AgentDetails and features/agents/tabs.tsx take AgentTypeView in place of RegisteredAgentType. Tests keep their RegisteredAgentType fixtures, which still satisfy the view.

Testing

  • tsc --noEmit passes. That check is the evidence for this change.
  • The Agents page and agents feature suites pass, except the Agents page avatar-picker test. It also fails on the base branch in my local worktree, whose node_modules is a symlink.

🤖 Generated with Claude Code

AgentsClient.types() returns AgentTypeView: what a type shows, its config
functions, its provider, models and usage calls, whether it is hosted,
and its session scope and change notice. Its runtime (run, runOnce,
hosted provisioning, session listing, expose) is no longer in the type
screens see. The Agents page, its dialogs and the settings tabs take the
view. Type-only: the service still hands screens its registered types.

Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Logan Johnson <loganj@squareup.com>
@loganj

loganj commented Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Closing: the Manager/Runner split replaces this design (#1748 → #1839, with more to come). The branch stays in place because #1737, #1743 and #1744 are still stacked on it. They will move onto the new stack in the hidden-page step.

@loganj loganj closed this Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant