Repository navigation
Conversation
AgentsClient.types() returns AgentTypeView: what a type shows, its config functions, its provider, models and usage calls, whether it is hosted, and its session scope and change notice. Its runtime (run, runOnce, hosted provisioning, session listing, expose) is no longer in the type screens see. The Agents page, its dialogs and the settings tabs take the view. Type-only: the service still hands screens its registered types. Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Logan Johnson <loganj@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
Summary
AgentsClient.types(), which returned the full registered type, includingrun,runOnce, hosted provisioning and the runtime's handles. The port client from feat(agents): serve the agents service to screens over a MessagePort #1725 will have to supplytypes()from another page, and it cannot supply a runtime.types()now returnsAgentTypeView, the part of a type that screens use. The compiler confirms that screens need nothing more. This is a type-only change, like refactor(agents): type the app's screens against an AgentsClient #1724: the service still returns its registered types, and they satisfy the view.Details
AgentTypeViewinfeatures/agents/service.tsholds:key,pluginId,revision,id),titleanddescription;icon,Peek,Create,CreateModel,tabs) and its config functions (AgentTypeConfig);provider(readiness store,check, attention action and its dialog parts);modelsandusagecalls;remote, kept only as presence (screens only test whether a type is hosted);sessionControlswith onlyscopeandsubscribe. The state and actions already go through the service'ssessionStateandsession.AgentTabs,AgentDetailsandfeatures/agents/tabs.tsxtakeAgentTypeViewin place ofRegisteredAgentType. Tests keep theirRegisteredAgentTypefixtures, which still satisfy the view.Testing
tsc --noEmitpasses. That check is the evidence for this change.node_modulesis a symlink.🤖 Generated with Claude Code