Repository navigation
Conversation
The port client now covers all of AgentsClient. A session's state is pushed once a screen asks for its place, and reads as unavailable until then; the harness's own change notice pushes it again. The retype preview is computed on the screens' side with retypePreview, from the shown agent's config and the types' config functions, which each type's UI entry presents there too. It refuses a missing or hosted type as the service does. Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Logan Johnson <loganj@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
Summary
AgentsClientreads were still missing from the port client:sessionState(key, place), which the composer reads to block a send while a session compacts, andpreviewRetype(key, type), which settings and the update review call when the owner picks another type.AgentsClient(pluspresent), so the screens' page can use it in place of the service. Nothing in the app uses the port yet, so behavior does not change.Details
sessionState: the first read of an agent and place asks the service for it, and reads asunavailableuntil the service pushes it.unavailableis the service's own answer for a session it cannot act on, so screens already handle it. After that, each push carries the place's state. The type's session-controls change notice already makes the service push (feat(agents): carry agent types and their handles over the agents port #1733).previewRetype: computed on the screens' side withretypePreview(refactor(agents): give screens a type's config functions through present #1727). It uses the shown agent's config and the two types' config functions, which each type's UI entry also presents in that page. It refuses an unknown agent, a missing type and a hosted type with the service's messages, and returns the config unchanged for the same type.AgentsPortClientis nowAgentsClient & { present }.Testing
service.test.ts, over the real service:tsc --noEmitpasses. The agents and Agents page suites pass, except the Agents page avatar-picker test, which also fails on the base branch in this worktree (itsnode_modulesis a symlink).🤖 Generated with Claude Code