Skip to content

Give the Runner its own class that owns the runner storage - #1752

Closed
loganj wants to merge 1 commit into
agents-presence-ownerfrom
agents-runner-owner
Closed

loganj wants to merge 1 commit into
agents-presence-ownerfrom
agents-runner-owner

Conversation

@loganj

@loganj loganj commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

🤖 This is step 4 of the Manager/Runner split for agents. It is an inert refactor.

What changes

AgentsService built the agent runners with about 30 callbacks, mixed in with its own state. This PR gives that part its own class, AgentsRunner (agents-runner.ts). It owns:

  • the agent runners,
  • the agent storage they keep: records, catch-up progress, turns in progress and synced config copies,
  • the agent storage migrations, which run first as before.

Everything the Runner needs from the rest of AgentsService (the Manager) now goes through one host type, RunnerManager. Examples are which agent runs, a community's live session, teams, agent create and update requests, and the classifier key.

Why

RunnerManager is the list of what will cross the agents link (#1748) once the Runner has its own hidden page. It is now written down in one place and type-checked, so each later slice can move one of its entries onto the link. Storage keys also now have clear owners: the Runner owns the keys above, and the Manager keeps teams, unfinished setups and archive checks.

Tests

No new tests: behavior is unchanged. The agents, harness and app suites pass (2,207 tests). The full vitest run fails only the emoji-picker tests that always fail in this local worktree.

🤖 Generated with Claude Code

AgentsRunner builds the agent runners and owns the storage they keep:
records, catch-up progress, turns in progress, synced config copies and
the storage migrations. What it needs from the rest of AgentsService, the
Manager, it asks through one RunnerManager host. That host is the list of
facts and requests the agents link will carry once the Runner has its own
page.

No behavior changes.

Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Logan Johnson <loganj@squareup.com>
@loganj

loganj commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Closing: this change is now part of #1748, which collects one column of the Manager/Runner split in one PR.

@loganj loganj closed this Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant