[kalvinnchau]

Summary

Offer to import communities saved by the previous Buzz desktop app for the signed-in identity. Every nonempty import requires explicit consent because current account state cannot establish whether old communities were previously removed. The prompt lists eligible origins and warns that importing may restore removed communities. Declining persists the decision.

The native reader opens the old macOS WebKit databases read-only, skips symlinks and propagates traversal/database errors so failures remain retryable. Only an absent root reads as empty. Import preserves existing settings and memberships and checks current state again after consent.

Test scope

At the author's explicit request, keep only one small importer test for this one-time startup migration. It checks that nothing is written before consent, approval adds the community and upload intent, and the completion marker prevents another read. Migration-specific test code drops from 734 lines to 56.

Remove the native fixtures, importer scenario matrix, dialog suite and added startup test. The previously added browser journey is also removed; no shared browser-build infrastructure is added. Native parsing/traversal, removal/sync permutations, retries, dismissal/lifecycle and app/browser integration no longer have dedicated migration regression coverage. Prior checks remain historical evidence, not permanent coverage. This deliberately accepts that coverage tradeoff to reduce ongoing test maintenance and execution for a one-time feature.

Validation

• The remaining importer test passed locally in a 533ms Vitest run.
• This follow-up changes test code only. Production migration behavior is unchanged.
• Mandatory commit/push hooks passed at afe0beb90. Latest-head CI run 40743552194 is pending for this reduction. Independent review approved the change with no findings. The prior head 3ddb185f7 passed CI run 40737395802.

Native GUI/IPC/OS-path acceptance and live relay reconnect remain unobserved. Optional skipped-entry diagnostics and importer simplification remain deferred.

[wesbillman]

🤖 Carl, an automated reviewer, commenting via Wes's GitHub account.

Verdict: one blocker and one product decision before merge. Reviewed head 10fc185 against main 6405ec8. The Royal Court split it into three lanes: native reader, importer, and an independent challenge.

Holds up:

• The importer computes and applies its sync state with no await in between, so it cannot clobber the Builderlab owner's acknowledgements.
• Interior symlinks are skipped, and the command takes no path argument.
• A targeted probe read committed UTF-16LE data while a WAL writer held an exclusive transaction.

Merge criteria

1. Traversal errors fail the read instead of completing the import (inline, legacy_communities.rs).
2. Decide whether the import may re-add relays the user already removed, and gate it if not (inline, legacy-communities.ts:110).
3. Run a real migration from an installed old Buzz once. Today's tests use fixture SQLite layouts that bypass root(), so WebKit discovery and the on-disk format are unproven.

The other inline comments are optional. CI is green at this head. Per this repo's AGENTS.md, this review is posted as a comment and not as Request Changes.