Repository navigation
Conversation
kalvinnchau
left a comment
There was a problem hiding this comment.
🤖 Two release compatibility findings; details inline.
| "macOS": { "entitlements": "entitlements.plist" }, | ||
| "macOS": { | ||
| "entitlements": "entitlements.plist", | ||
| "minimumSystemVersion": "10.15" |
There was a problem hiding this comment.
🤖 [P2] Align the Intel minimum OS with the frontend WebKit requirements
The 10.15 gate admits Catalina, whose latest WebKit is Safari 15.6.1, but Vite 8's default build target here includes Safari 16.4 and the frontend uses Tailwind 4 plus color-mix(), which require newer WebKit. Thus an Intel Catalina installation passes the OS gate despite unsupported frontend features. The source compatibility mismatch is established; exact Catalina rendering/JS failure was not exercised. Raise and document the minimum to a supported OS/WebKit combination (macOS 11 with sufficiently updated WebKit is the proposed floor), or explicitly support and test the older frontend target; lowering only the JS target does not address Tailwind's requirements.
eb44153 to
59b15f1
Compare
wesbillman
left a comment
There was a problem hiding this comment.
🤖 Star Lord’s automated source review via Wes’s account.
- P1: The existing Hermit/rustup finding remains applicable. At this head, the affected compilation is now
buzz-agent-command; the outer target-library check still does not cover the nested compiler. Preserve an absolute rustup compiler selection through the command chain and validate that path. - PR material: Correct the 10.15 minimum-OS claim and distinguish historical validation from this revision. The unchanged Tauri configuration requires macOS 12.0, and the bundled Goose pin is now 1.57.0.
- Optional docs:
docs/releases.md:66–68should distinguish arm64 verification at promotion from both macOS architectures’ build-time checks.
Rocket, Mantis and Groot completed independent lanes. Head 59b15f118f6383c52601b3baabdeb7a98d82696f; base e210c8a472cc49ee7c0b49b62bfad10fd5ef4c8e. Source-only: no builds/tests or app execution. Required CI passed in the snapshot; signed Intel packaging, install/update behavior and release-job cost remain unverified.
Build the macOS preview job as an aarch64/x64 matrix. The Intel leg cross-compiles x86_64-apple-darwin on the Apple Silicon runner with the pinned Rust release from rustup, since Hermit's Rust ships only the host standard library. Both legs are signed, notarized and verified, and the preview feed gains a darwin-x86_64 updater entry. Co-authored-by: Jitter <2b2e6415e748c35180847a37aadae06a11e30dddc76b784e7fd9354c4eb42e7a@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Matt Toohey <contact@matttoohey.com>
59b15f1 to
517c523
Compare
Summary
Publishes a signed, notarized Intel macOS DMG (
Buzz_<version>_x64.dmg) and updater archive next to the Apple Silicon one in every desktop preview. Intel installs also get adarwin-x86_64entry in the preview updater feed. Buzz 0.X shipped an Intel build (block/buzzrelease-macos-x64), but buzz-app only had the arm64 job, so Intel users (e.g. 2020/2021 Intel Macs) had nothing to install.release.yml: the macOSbuildjob is now a matrix overaarch64-apple-darwin/x86_64-apple-darwin. Both legs build with--target, sign and notarize through the same action, and check that the app executable,goose-acpandbuzz-agent-commandmatch the leg's architecture.publishverifies and assembles both macOS artifacts.promote_previewdownloads and verifies the x64 updater archive too.buzz-foundationexecutable fallback in promotion is gone: no preview with that name can be promoted any more, because none has an x64 archive.x86_64-apple-darwinstd, the same way the Windows job selects the pin.scripts/preview-feed.mjsandscripts/prune-preview-releases.mjsgaindarwin-x86_64→Buzz_<version>_x64.app.tar.gz.tauri.conf.json: setsbundle.macOS.minimumSystemVersionto10.15, so Intel Macs on older macOS get the system's "requires a newer macOS" message instead of a crash. We previously inherited Tauri's default10.13. Apple Silicon is unaffected: its floor is 11.0 either way.docs/releases.mdnow list the Intel DMG.Validation
minimumSystemVersion: 10.15. The IntelInfo.plistnow saysLSMinimumSystemVersion10.15, andBuzzlinks with minos 10.15 (Tauri passes it to the cargo build). The sidecars keep a 10.12 floor, which is below the launch gate.goose-acp --versionprintsgoose-acp 1.56.0, andbuzz-agent-commandgives its expected usage error. I didn't launch the app itself, so my installed Buzz profile wasn't touched.pnpm tauri build --ci --no-sign --bundles dmg --target x86_64-apple-darwin, Rust 1.98.1 plus the official x86_64 std) producedBuzz_0.7.0_x64.dmg(35 MiB).lipo -archsshowsx86_64forBuzz,goose-acpandbuzz-agent-command, and none of them link non-system libraries.node --testpasses fordesktop-release,preview-feed,prune-preview-releasesandpackaging(21/21). New coverage: a missing Intel artifact blocks publication, and there are assertions on the matrix and on--target. Oneb441539, the fullnode --test tests/integration/*.test.mjsrun gives 228/229. The one failure,macOS launchers preserve icon…inworktree-icon.test.mjs, fails the same way on a cleanorigin/main(10039529).Not yet validated / rollout notes
main, so the first scheduled run after merge is the first real signed Intel build. Candidate-only runs don't build macOS.🤖 Generated with Claude Code