Repository navigation
feat(attention): open comment-author settings from GitHub watches - #1827
Open
johnmatthewtennant wants to merge 1 commit into
Open
johnmatthewtennant wants to merge 1 commit into
johnmatthewtennant wants to merge 1 commit into
Conversation
johnmatthewtennant
force-pushed
the
jtennant/poppy/attention-source-presentation
branch
from
October 28, 2026 18:36
e08b1bd to
ea767dd
Compare
johnmatthewtennant
force-pushed
the
jtennant/poppy/github-author-allowlist
branch
2 times, most recently
from
October 28, 2026 20:29
2649215 to
13fe4ff
Compare
johnmatthewtennant
force-pushed
the
jtennant/poppy/attention-source-presentation
branch
from
October 28, 2026 20:29
ea767dd to
97aebcb
Compare
johnmatthewtennant
force-pushed
the
jtennant/poppy/github-author-allowlist
branch
from
October 28, 2026 20:32
13fe4ff to
a6c7d54
Compare
johnmatthewtennant
force-pushed
the
jtennant/poppy/attention-source-presentation
branch
from
October 28, 2026 20:32
97aebcb to
ccf05dc
Compare
johnmatthewtennant
force-pushed
the
jtennant/poppy/github-author-allowlist
branch
from
October 29, 2026 00:32
a6c7d54 to
6e15c86
Compare
johnmatthewtennant
force-pushed
the
jtennant/poppy/attention-source-presentation
branch
from
October 29, 2026 00:32
ccf05dc to
e33cedc
Compare
johnmatthewtennant
force-pushed
the
jtennant/poppy/github-author-allowlist
branch
from
October 29, 2026 01:43
6e15c86 to
61ebd33
Compare
johnmatthewtennant
force-pushed
the
jtennant/poppy/attention-source-presentation
branch
from
October 29, 2026 01:44
e33cedc to
c13637f
Compare
johnmatthewtennant
force-pushed
the
jtennant/poppy/github-author-allowlist
branch
from
October 29, 2026 02:57
61ebd33 to
ee70d24
Compare
johnmatthewtennant
force-pushed
the
jtennant/poppy/attention-source-presentation
branch
from
October 29, 2026 02:57
c13637f to
966e0e2
Compare
johnmatthewtennant
changed the title
johnmatthewtennant
force-pushed
the
jtennant/poppy/attention-source-presentation
branch
from
October 29, 2026 03:05
966e0e2 to
012a264
Compare
johnmatthewtennant
force-pushed
the
jtennant/poppy/github-author-allowlist
branch
from
October 29, 2026 05:57
310dece to
32fd8a8
Compare
johnmatthewtennant
force-pushed
the
jtennant/poppy/attention-source-presentation
branch
from
October 29, 2026 05:57
012a264 to
8f803e8
Compare
johnmatthewtennant
force-pushed
the
jtennant/poppy/github-author-allowlist
branch
from
October 29, 2026 10:51
32fd8a8 to
e0b866d
Compare
johnmatthewtennant
force-pushed
the
jtennant/poppy/attention-source-presentation
branch
from
October 29, 2026 10:51
8f803e8 to
2cb0c66
Compare
johnmatthewtennant
force-pushed
the
jtennant/poppy/github-author-allowlist
branch
from
October 29, 2026 10:54
e0b866d to
44bcbb2
Compare
johnmatthewtennant
force-pushed
the
jtennant/poppy/attention-source-presentation
branch
from
October 29, 2026 10:54
2cb0c66 to
61c071d
Compare
johnmatthewtennant
force-pushed
the
jtennant/poppy/github-author-allowlist
branch
from
October 29, 2026 11:23
44bcbb2 to
2c7383e
Compare
johnmatthewtennant
force-pushed
the
jtennant/poppy/attention-source-presentation
branch
5 times, most recently
from
October 29, 2026 17:27
427df9c to
09c9e84
Compare
johnmatthewtennant
force-pushed
the
jtennant/poppy/github-author-allowlist
branch
from
October 29, 2026 18:27
34f4f97 to
88d72e4
Compare
johnmatthewtennant
force-pushed
the
jtennant/poppy/attention-source-presentation
branch
from
October 29, 2026 19:09
09c9e84 to
4be4839
Compare
Agent Attention hardcoded how GitHub pull request watches look: their kind, icon, repo#number target, Open on GitHub link and details. An Attention source can now present its watches with `present`, and the page asks the watch's provider through `agents.presentWatch`, falling back to the watch's name when the provider has none or it throws. The GitHub plugin now owns its presentation, and a PR watch's details link to its comment author settings with "Choose who can wake agents". Co-authored-by: Poppy <ace4dfe51b23bb4244ab9117dfd5e13b8239445e333225608c352e68cb3fe2b5@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: John Tennant <jtennant@block.xyz>
johnmatthewtennant
marked this pull request as ready for review
October 29, 2026 19:24
johnmatthewtennant
force-pushed
the
jtennant/poppy/attention-source-presentation
branch
from
October 29, 2026 19:26
4be4839 to
d91520d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
GitHub comment author rules decide whose pull request feedback wakes agents, but a GitHub watch in an agent's Watching tab gave no way to find them. The tab also hardcoded the GitHub provider, parsing the PR URL and building its icon and link itself, so the GitHub plugin could not change how its own watches look.
What
presentits watches. Given a watch and its display name, it returns a kind and, optionally, an icon, a target with a subtitle, an external link and a details component.agents.presentWatchfinds the watch's provider and callspresent. If the provider has nopresent, or it throws, the tab falls back to the watch's name, so one plugin's mistake can't break it.Validation
agent-attention.spec.mjs, in Chromium and WebKit, renders the GitHub plugin's real presentation in the Watching tab, expands a PR watch and clicks "Choose who can wake agents", which navigates to thebuzz.github/authorssettings.Not tested: a watch created by a real agent through
github_watch_pr. The spec renders a modeled watch with the real GitHub presentation.Screenshots
An expanded GitHub PR watch with the link to author settings