Repository navigation
ci: cache the built Goose executable for desktop previews - #1838
Draft
jameskraus wants to merge 1 commit into
Draft
jameskraus wants to merge 1 commit into
jameskraus wants to merge 1 commit into
Conversation
Reuse only exact matches from normal main releases and bind cache keys to native build inputs. Verify the staged executable against its checksum before skipping compilation. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: James Kraus <jamespkraus@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop previews rebuild the same pinned Goose executable before every Buzz build. In run 40697350997, Goose compilation took 12m 05s on macOS and 13m 55s on Windows.
Cache the unsigned executable and its build stamp for normal main releases on all three platforms. A shared action accepts only exact cache matches, with keys covering the native target, tool pins, build configuration, and runner image or installed Linux packages. The build script now checks the executable's SHA-256 and file properties before reuse. Candidate-only runs remain uncached; signing and package verification still run on every release.
Oracle (GPT-6 Astra Pro) recommended this approach after reviewing cache trust and invalidation. The checksum detects corrupted bytes; it does not authenticate a cache producer. The cache retains GitHub's branch isolation and is consumed/written only by normal main release jobs. Final autoreview found no P0/P1 blockers.
Checks: 16 focused build-script/archive tests and seven existing release tests pass, along with actionlint, local composite-action shell checks, and mandatory hooks. The original script failed the modified/empty/non-executable cache regression cases. Compiler, git, and otool subprocesses are fixture stand-ins; these checks do not prove native builds or GitHub cache transport.
Hosted cold/warm release runs and human acceptance remain pending. The 12–14 minutes is avoidable compilation observed in the earlier run, not a measured speedup from this patch. No browser cases were added or removed.