Repository navigation
fix(agents): explain unavailable harnesses accurately - #1883
Merged
Merged
Conversation
Co-authored-by: Carl <acda9e433d19dcd0e6b6840f7f4b98f3a56f1fab98049d444c087019e6d36560@feedback.communities.buzz.xyz> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
tellaho
marked this pull request as ready for review
October 29, 2026 04:53
Contributor
Author
|
🤖 Independent agent review by Princess Donut, posted from Taylor's account on Taylor's behalf. Reviewed head BlockersNone. Verified
Optional suggestions
Not covered by this reviewI didn't exercise the live app and didn't repeat local tests, since CI and the earlier push gates cover them. The human test of the real flow is still outstanding. |
kazemek21
approved these changes
Oct 29, 2026
kazemek21
left a comment
Contributor
There was a problem hiding this comment.
Kyle reviewed this PR and the Nexus review-tracker notes and approves.
Posted by Codex (gpt-6.1-sol) on behalf of kylez
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Category: fix
User Impact: Agents with an unavailable harness now show recovery guidance instead of incorrectly saying they run on another device.
Problem: When an agent's harness is missing from the client, Agents labels it “On another device” and says another device holds its key. That explanation can be false for hosted agents whose plugin or configuration is unavailable.
Solution: Show “Harness unavailable” and direct users to Settings → Plugins or a build with the harness configured. Keep the existing other-device explanation for recognized local harnesses.
Changes
File changes
src/bundled/agents/AgentsPage.tsx
Use the registered harness type to choose the card summary and read-only detail guidance.
src/bundled/agents/AgentsPage.test.tsx
Cover an unavailable hosted harness: show recovery guidance, omit the other-device claim, and retain read-only behavior.
This is the standalone AgentsPage patch extracted from #1881; provider setup and runtime changes are excluded.
Reproduction steps
Validation
At
aba84924710b4a5cad88e4e4a2d69c2bc75d4ae9, with a clean working tree:git diff --checkpassed. The two-file patch has the same stable patch ID as its source in fix(builderlab): default unconfigured builds to production #1881 (6034b53b4d11a86794e3dcf2b65551d7bd4c8782).Hosted CI passed all jobs except WebKit 9/12. That job failed before its activation assertions in unchanged
solo-rename.spec.mjs:496:clock.pauseAt(new Date())rejected moving the browser clock into the past. The same test passed at current maine210c8a47(main CI); neither the test nor the Solo implementation differs in this PR. An isolated headless WebKit clock probe reproduced the exact error when its installed clock was ahead of the runner, while the same-file anchored-clock pattern passed.The failed job and its dependents were rerun once without code changes: attempt 2. Completion is pending. Broad CI-equivalent suites were not duplicated locally.
Agent source review
Carl reviewed the final diff and traced registered-type lookup, service inventory classification, card summaries, and AgentPeek selection at
aba849247. No source-level blockers found: missing harnesses receive recovery guidance, recognized local harnesses retain the existing explanation, and read-only actions are unchanged. The change reuses AgentCard/PeekIdentity and their existing typography, consistent with the design guide’s collection/detail and contextual-recovery rules. This was self-review by the implementer, not independent review.Screenshots / remaining checks
Real-app capture was attempted again headlessly against the existing running build. That isolated browser session stops at Join a community with no configured community/browser identity. Agents also depends on native Tauri custody (
nativeAgents()and the service's unavailable state), which this browser session does not provide. The changed production flow was not exercised; component/unit coverage does not establish native acceptance.Remaining checks: the CI rerun, actual-app flow and screenshots (including theme/width/enlarged-text and keyboard checks), human testing, and independent review if required. Human testing and review approval remain with the maintainer; no completion attestation has been added.