fix(buzz-acp): raise MODELS_TIMEOUT to 60s so slow-start agents don't fail models/probe subcommands - #6564
Open
paramiao wants to merge 1 commit into
Open
Conversation
buzz-acp helper subcommands (models/methods/initialize probe) use a hardcoded 10s timeout, but cold-starting ACP servers (e.g. Node-based openclaw acp, ~11.4s to first initialize response) fail the probe despite being functional. Raise the helper-subcommand timeout constant to 60s, matching the runtime agent-pool initialize timeout for consistent behavior. Alternative considered: env-configurable timeout (BUZZ_ACP_MODELS_TIMEOUT); kept minimal single-constant change here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UPSTREAM-PR-DESC — buzz-acp models 超时修复 PR 草稿
github.com/block/buzz(main 分支,草稿基线 = commitf995325,2026-08-22 HEAD)UPSTREAM-PR-DRAFT.patch(干净可提交形态;本地 fork 版含标注注释,在/home/mk/buzz-huanxi/build/models-timeout.patch)PR Title(建议)
PR 描述(建议正文)
Problem
buzz-acplightweight helper subcommands (models,methods, and the initialize probe path) areguarded by a hardcoded
MODELS_TIMEOUT = 10s(crates/buzz-acp/src/lib.rs,const MODELS_TIMEOUT).Any ACP agent whose process spawn +
initializehandshake takes longer than 10s cold fails thesesubcommands with
error: agent timed out (10s), even though the agent is fully functional.Reproducible case:
openclaw acp(Node.js-based ACP server, v2026.7.1) takes ~11.4s from spawn tofirst
initializeresponse on a cold start. Result:Meanwhile the runtime agent-pool path already uses a 60s timeout for the exact same
client.initialize()call, so the runtime bridge works fine while the helper subcommands fail —inconsistent behavior for the same operation.
Proposed fix (minimal)
Raise the helper-subcommand timeout constant from 10s to 60s, matching the runtime agent-pool
initialize timeout. Single-constant change, no behavior change for fast agents beyond a later
timeout error.
Alternative (happy to switch if preferred): make it configurable, e.g.
BUZZ_ACP_MODELS_TIMEOUTenv var with a 60s default — useful for agents with even slower coldstarts (JVM, heavy Python envs). We kept the minimal diff here since 60s already matches the
runtime path constant.
Evidence
session/newat 12.19s (measured againstopenclaw-acp v2026.7.1-2, stdio probe).
models→error: agent timed out (10s)(reproduced twice).models→ exit 0, agent identity reported correctly;runtime agent-pool behavior unchanged.
Testing
buzz-acp modelsagainst openclaw ACP agent: timeout → PASS after patchbuzz-acp models --json: structured agent name/version output correctagent_pool_ready agents=1(runtime path unaffected)提交前 checklist(itops 执行,待 main 确认后进行)
git diff重新生成(UPSTREAM-PR-DRAFT.patch 的 index hash 是草稿基线的,正式提交前需重算)内部注意