Repository navigation
Conversation
A registry keyed on the operation shape needs to walk every shape to prove none is unclassified, as the refusal registry walks Kinds().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exports
statement.OpKinds(), the closed set of operation shapes, with a test that it matches exactly theOpKindconstantsops.godeclares.Why
A registry of the operations pg-sprite can run that cannot be undone is coming next. Its completeness test has to walk every operation shape and fail when a new one is unclassified, the way
TestRefusalRegistryIsCompletewalksstatement.Kinds(). Statement kinds have that accessor; operation shapes do not.What
statement.OpKinds()returns everyOpKind,OpUnrecognizedfirst.TestOpKindsIsClosedAndDescribedparses theops.goiota block and fails ifOpKinds()misses or duplicates a constant, or if a shape falls through to the catch-allDescribe()label.declaredIotaValuesnow takes the file to parse, so the same check readsops.goas well asstatement.go.No behaviour changes: nothing calls
OpKinds()yet.Before / after
A later PR adds
OpDropPolicyto theops.goiota block and forgets the new list.🤖 Generated with Amp (Claude Opus 4.6)