Repository navigation
Conversation
--quiesced was renamed to --block-writes SCHEMA.TABLE, but the guide merged with the old flag. Operator-facing docs now say offline mode and --block-writes; the engine's internal term, a quiesced target, is kept.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
🤖 Correctness review performed by Jash’s AI agent at head Verdict: no actionable defect found in the documentation diff. The offline and restart examples acknowledge the same Verified: reviewed the complete seven-file diff, PR description, existing comments, and reported CI. All 16 checks are successful, including documentation guards, build, PostgreSQL 14–18, Supabase, and the built-artifact smoke test. The separate automated Codex review failed because of usage limits. No local build, tests, or PostgreSQL example runs were performed; exact-head surrounding source and inline-thread retrieval were unavailable. Consequently the CLI’s current acknowledgement enforcement and the recaptured output were not independently reproduced here; the author’s execution report remains supporting evidence, not a test I ran. No required action items from this review. Generated by Codex. |
|
🤖 Product review by Jash’s AI agent at OSS adoption: SchemaBot integration: the edits preserve the library terminology and existing outcome, refusal, and recovery contracts; no adapter API changes appear in this diff. The distinction between requested offline mode and the observed Generated by Codex. |
JashLal
left a comment
There was a problem hiding this comment.
🤖 Approving on Jash’s behalf after the full-diff documentation review at 66c34f5. No actionable defect found; all 16 reported CI checks pass. Exact-head surrounding source and inline threads were unavailable, and no local build, tests or database examples ran. Verification limits are disclosed in the comments. Generated by Codex.
Switches the copy-and-swap operator guide and the other operator-facing docs from
--quiescedto--block-writes SCHEMA.TABLE, which #260 renamed the flag to.Why
#263 merged the copy-and-swap guide while it still used
--quiesced. That flag no longer exists: the CLI rejects it as an unknown flag. An operator following the guide, the README'smigraterow, or the CLI output examples therefore hits a usage error. Some operator-facing prose in the integration and engine-role docs still said "quiesced run" for what the CLI now calls a run that blocks writes.What
docs/copy-and-swap.md:--block-writes SCHEMA.TABLE.--block-writes public.order_archive, and the JSONdetailis recaptured from main's build ("writes to the table were blocked for the length of the run").--block-writesagain.README.mdmigraterow,docs/README.mdindex, anddocs/cli-output-examples.md:--block-writes, with the link pointing to the new#live-or-offlineanchor.docs/schemabot-integration.mdanddocs/engine-role.md: operator-facing "quiesced run/row" becomes "a run that blocks writes". Where the docs map to the engine (cutover-unfenced, theRunner), "quiesced target" stays, since that is the engine's own term.pkg/migrate/desired_copy_swap.go: one comment says "block-writes acknowledgement".The guide's outputs were run against PostgreSQL 16 with main's build:
Before / after
An operator on a server without logical decoding, following the guide's offline example:
🤖 Generated with Amp (Claude Opus 4.6)