Repository navigation
refactor: keep protobuf messages at the server API boundary - #74
Merged
Merged
Conversation
alecthomas
marked this pull request as ready for review
October 28, 2026 10:12
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Storage, the reporter, and the command line passed generated protocol messages around, which tied the internals to the public protocol and spread validation across callers. Converting at the API boundary lets every other package work with validated domain values, and the architecture linter now rejects protocol imports outside it. The Redis backend stores JSON of the domain type instead of protobuf. It has not been released, so existing data needs no migration. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alecthomas
force-pushed
the
aat/protobuf-at-api-boundary
branch
from
October 28, 2026 10:31
66160ba to
c8b7da9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated protocol messages were passed through storage, the mirror's reporter, and the command line. That tied the internals to the public protocol and left validation to whoever happened to hold a message. This change converts messages at the server's API boundary, so everything else works with validated domain values.
wirepackage holds every conversion between protocol messages and domain types. It validates reported divergences as it converts them. The server's handler and its client share it.divergences --jsonprints the same protocol JSON as before.architecturelinter now rejects imports ofspectrepbandspectrepbconnectoutside the handler,wire, and the client.🤖 Generated with Claude Code