Repository navigation
feat(server): add support for Redis clusters - #76
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alecthomas
force-pushed
the
aat/redis-cluster-storage
branch
from
October 28, 2026 11:19
236f761 to
613551b
Compare
alecthomas
marked this pull request as ready for review
October 28, 2026 11:19
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SPECTRE server could store divergences only in a single Redis server. This adds support for a Redis Cluster.
--storageselects cluster mode with theredis-cluster://andrediss-cluster://schemes. Further seed nodes go inaddrquery parameters, such asredis-cluster://localhost:7000?addr=localhost:7001. go-redis parses single-node and cluster URLs with the sameredisandredissschemes, so a separate scheme is needed to choose between them.redis://URLs keep using the single-node client.UniversalClient, which both clients satisfy. Every command touches the one divergences key, which lives in a single slot, soWATCHtransactions work unchanged in a cluster.The tests run the shared store tests and
Openagainst a cluster client. They use miniredis, which acts as a one-node cluster owning every slot. As a result, redirects between nodes are not exercised.This is stacked on #75.
🤖 Generated with Claude Code