Skip to content

Remove aid (deprecated) — release 0.19.0 - #152

Merged
blooop merged 1 commit into
mainfrom
feat/remove-deprecated-aid
Aug 7, 2026
Merged

blooop merged 1 commit into
mainfrom
feat/remove-deprecated-aid

Conversation

@blooop

@blooop blooop commented Aug 7, 2026 •

Copy link
Copy Markdown
Owner

Closes #151.

aid here reached a repo through renv/rocker, composing and building an image per launch. devlaunch's dl drives devpod and reuses the workspace it already has for that branch. Both packages installed an aid entry point, so which one you got — and whether your container was rebuilt or reused — came down to which was later on PATH.

devlaunch 0.0.9 (blooop/devlaunch#75) ships an aid with no container machinery of its own: it rewrites its command line into a dl one, so there is a single path to a workspace and nothing left to drift.

Removed

  • rockerc/aid.py
  • the aid = "rockerc.aid:main" entry point
  • rockerc/completions/aid.bash, and its line in the completion installer
  • test/test_aid.py

rockerc, renv, renvvsc, rockervsc and dp are untouched. Nothing imported rockerc.aid — the only references outside the deleted files were the entry point, the completion installer, and historical specs/ planning docs, which are left as the record they are.

What deliberately stays

The aid entries in completion.py's _LEGACY_BLOCKS and _LEGACY_SINGLE_LINES. They are cleanup, and removing aid is exactly when they earn their keep: an rc file written by an earlier rockerc still carries aid's completion block and its complete -F _aid_completion aid line, completing a command that no longer exists. rockerc --install now strips them. New test test_install_removes_a_leftover_aid_completion covers it.

Tests

245 pass. The 11 failures in test/workflows/ are docker: command not found in the sandbox this ran in — environmental, and they fail the same way on main.

Release

Version bumped 0.18.0 → 0.19.0 with a [0.19.0] changelog entry, so merging to main triggers the auto-publish workflow.

Note for anyone who used the flags

devlaunch's aid defaults to --claude rather than --gemini, and has no equivalent yet for the gemini-only -y/--yolo and -f/--flash.

🤖 Generated with Claude Code

Summary by Sourcery

Remove the deprecated aid command and its integration, and bump rockerc to version 0.19.0.

Enhancements:

  • Update shell completion installation to handle legacy aid completion blocks and ensure dp completions are installed instead.
  • Clarify completion installation help text to reflect the current set of supported commands.

Documentation:

  • Add 0.19.0 changelog entry documenting the removal of aid, its rationale, and behavioral differences in the replacement.

Tests:

  • Adjust completion install tests for the removal of aid and add coverage ensuring legacy aid completions are stripped from user rc files.

Chores:

  • Remove aid-related source file, entry point wiring, completion script, and tests from the project configuration and tree.

aid here reached a repo through renv/rocker, composing and building an image per
launch, while devlaunch's dl drives devpod and reuses the workspace it already
has for that branch. Both packages installed an aid entry point, so which of the
two you got — and whether your container was rebuilt or reused — came down to
which was later on PATH.

devlaunch 0.0.9 ships an aid with no container machinery of its own: it rewrites
its command line into a dl one, so there is a single path to a workspace and
nothing left to drift. This one goes: rockerc/aid.py, the entry point, its
completion script and its tests.

The aid entries in completion.py's legacy tables stay, and they are the point of
staying: an rc file written by an earlier rockerc still carries aid's completion
block and its `complete` line, so rockerc --install cleans up after the command
it no longer installs. A test covers that.

rockerc, renv, renvvsc, rockervsc and dp are untouched.

Release 0.19.0.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @blooop, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@sourcery-ai

sourcery-ai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Reviewer's Guide

Removes the deprecated aid command, associated entry point, completion script, and tests, while preserving legacy completion cleanup behavior and updating versioning and changelog for the 0.19.0 release.

Flow diagram for completion installation and legacy aid cleanup

flowchart TD
    actor_user[User]
    actor_user --> rockerc_cli[rockerc --install]

    rockerc_cli --> install_all_completions[install_all_completions]
    install_all_completions --> _completion_file_path[_completion_file_path]
    install_all_completions --> read_rc[read existing rc file]
    read_rc --> strip_legacy[[strip legacy blocks including aid entries]]

    install_all_completions --> rockerc_script[_rockerc_bash_completion_script]
    install_all_completions --> load_completion_script_renv[load_completion_script renv]
    install_all_completions --> load_completion_script_dp[load_completion_script dp]

    rockerc_script --> combine[combine completion scripts without aid]
    load_completion_script_renv --> combine
    load_completion_script_dp --> combine

    strip_legacy --> write_rc[write updated rc file]
    combine --> write_rc
Loading

File-Level Changes

Change Details Files
Remove the deprecated aid CLI entry point and its implementation from rockerc.
  • Deleted the rockerc/aid.py module implementing the aid command.
  • Removed the aid = "rockerc.aid:main" entry point from pyproject.toml.
  • Deleted the test/test_aid.py test suite for the aid command.
  • Removed the rockerc/completions/aid.bash completion script and its inclusion in the combined completion output.
rockerc/aid.py
pyproject.toml
test/test_aid.py
rockerc/completions/aid.bash
Adjust shell completion installation to drop legacy aid completions while keeping other tools intact.
  • Updated install_all_completions docstring and combined script to cover rockerc, renv/renvvsc, and dp only.
  • Stopped loading the aid completion script and ensured dp completion is present instead.
  • Documented legacy completion blocks including aid so that rockerc --install strips old aid completion sections from user rc files.
  • Added test_install_removes_a_leftover_aid_completion to verify that running completion install removes stale aid completion blocks and complete lines from the rc file and completion file.
  • Updated existing completion installation tests to assert # dp completion instead of # aid completion.
  • Ensured legacy _LEGACY_BLOCKS handling continues to remove old aid entries from rc files on install.
rockerc/completion.py
test/test_completion_install.py
Version and changelog updates for the 0.19.0 release reflecting the aid removal.
  • Bumped project version from 0.18.0 to 0.19.0 in pyproject.toml.
  • Added a [0.19.0] section to CHANGELOG.md describing the removal of aid, its collision with devlaunch’s aid, and behavioral notes for users of its flags.
  • Left other tools (rockerc, renv, renvvsc, rockervsc, dp) explicitly marked as unaffected in the changelog.
pyproject.toml
CHANGELOG.md
pixi.lock

Assessment against linked issues

Issue Objective Addressed Explanation
#151 Remove the deprecated aid CLI and all its associated code (module, entry point, completion script, tests) without affecting other entry points (renv, renvvsc, rockerc, rockervsc, dp). ✅
#151 Update shell completion installation so it no longer installs aid completions, while still cleaning up legacy aid completion blocks and complete lines from users' rc files. ✅
#151 Document the removal of aid, its replacement by devlaunch's aid, and the behavioral differences (e.g., default model and missing gemini-only flags) in the project changelog for the new release. ✅

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@blooop
blooop merged commit b1a0bea into main Aug 7, 2026
7 checks passed
@blooop
blooop deleted the feat/remove-deprecated-aid branch August 7, 2026 21:46
@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.00%. Comparing base (e097aca) to head (bbce136).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
- Coverage   63.04%   63.00%   -0.04%     
==========================================
  Files           9        8       -1     
  Lines        1840     1768      -72     
==========================================
- Hits         1160     1114      -46     
+ Misses        680      654      -26     
Files with missing lines Coverage Δ
rockerc/completion.py 90.90% <ø> (+1.51%) ⬆️

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove aid: superseded by devlaunch's aid

1 participant