Repository navigation
Remove aid (deprecated) — release 0.19.0 - #152
Merged
Merged
Conversation
aid here reached a repo through renv/rocker, composing and building an image per launch, while devlaunch's dl drives devpod and reuses the workspace it already has for that branch. Both packages installed an aid entry point, so which of the two you got — and whether your container was rebuilt or reused — came down to which was later on PATH. devlaunch 0.0.9 ships an aid with no container machinery of its own: it rewrites its command line into a dl one, so there is a single path to a workspace and nothing left to drift. This one goes: rockerc/aid.py, the entry point, its completion script and its tests. The aid entries in completion.py's legacy tables stay, and they are the point of staying: an rc file written by an earlier rockerc still carries aid's completion block and its `complete` line, so rockerc --install cleans up after the command it no longer installs. A test covers that. rockerc, renv, renvvsc, rockervsc and dp are untouched. Release 0.19.0.
Contributor
Reviewer's GuideRemoves the deprecated Flow diagram for completion installation and legacy aid cleanupflowchart TD
actor_user[User]
actor_user --> rockerc_cli[rockerc --install]
rockerc_cli --> install_all_completions[install_all_completions]
install_all_completions --> _completion_file_path[_completion_file_path]
install_all_completions --> read_rc[read existing rc file]
read_rc --> strip_legacy[[strip legacy blocks including aid entries]]
install_all_completions --> rockerc_script[_rockerc_bash_completion_script]
install_all_completions --> load_completion_script_renv[load_completion_script renv]
install_all_completions --> load_completion_script_dp[load_completion_script dp]
rockerc_script --> combine[combine completion scripts without aid]
load_completion_script_renv --> combine
load_completion_script_dp --> combine
strip_legacy --> write_rc[write updated rc file]
combine --> write_rc
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
==========================================
- Coverage 63.04% 63.00% -0.04%
==========================================
Files 9 8 -1
Lines 1840 1768 -72
==========================================
- Hits 1160 1114 -46
+ Misses 680 654 -26
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #151.
aidhere reached a repo throughrenv/rocker, composing and building an image per launch. devlaunch'sdldrives devpod and reuses the workspace it already has for that branch. Both packages installed anaidentry point, so which one you got — and whether your container was rebuilt or reused — came down to which was later onPATH.devlaunch 0.0.9 (blooop/devlaunch#75) ships an
aidwith no container machinery of its own: it rewrites its command line into adlone, so there is a single path to a workspace and nothing left to drift.Removed
rockerc/aid.pyaid = "rockerc.aid:main"entry pointrockerc/completions/aid.bash, and its line in the completion installertest/test_aid.pyrockerc,renv,renvvsc,rockervscanddpare untouched. Nothing importedrockerc.aid— the only references outside the deleted files were the entry point, the completion installer, and historicalspecs/planning docs, which are left as the record they are.What deliberately stays
The
aidentries incompletion.py's_LEGACY_BLOCKSand_LEGACY_SINGLE_LINES. They are cleanup, and removingaidis exactly when they earn their keep: an rc file written by an earlier rockerc still carries aid's completion block and itscomplete -F _aid_completion aidline, completing a command that no longer exists.rockerc --installnow strips them. New testtest_install_removes_a_leftover_aid_completioncovers it.Tests
245 pass. The 11 failures in
test/workflows/aredocker: command not foundin the sandbox this ran in — environmental, and they fail the same way onmain.Release
Version bumped 0.18.0 → 0.19.0 with a
[0.19.0]changelog entry, so merging tomaintriggers the auto-publish workflow.Note for anyone who used the flags
devlaunch's
aiddefaults to--clauderather than--gemini, and has no equivalent yet for the gemini-only-y/--yoloand-f/--flash.🤖 Generated with Claude Code
Summary by Sourcery
Remove the deprecated
aidcommand and its integration, and bump rockerc to version 0.19.0.Enhancements:
aidcompletion blocks and ensuredpcompletions are installed instead.Documentation:
aid, its rationale, and behavioral differences in the replacement.Tests:
aidand add coverage ensuring legacyaidcompletions are stripped from user rc files.Chores:
aid-related source file, entry point wiring, completion script, and tests from the project configuration and tree.