feat: pull with retries before building#809
Open
HastD wants to merge 1 commit into
Open
Conversation
gmpinder
approved these changes
Jul 2, 2026
gmpinder
requested changes
Jul 2, 2026
gmpinder
left a comment
gmpinder
left a comment
Member
There was a problem hiding this comment.
Looks like there's a bug in the logic you introduced. It's trying to pull images that don't exist yet
Collaborator
Author
|
Oops, I see the issue, it's trying to pull the image to be created, but it should pull the base image instead. One sec, fixing it. |
This should reduce the frequency of build failures caused by network/server issues when pulling a remote image before building. Additionally, improve the retry utility functions: * Make the retry functions accept a `Duration` rather than a `u64` representing seconds. This makes it clear at the call site that the argument represents a duration. * Make `retry_async` use `tokio::time::sleep` instead of the blocking `std::thread::sleep`. Async functions shouldn't block for an extended period of time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should reduce the frequency of build failures caused by network/server issues when pulling a remote image before building.
Additionally, improve the retry utility functions:
Durationrather than au64representing seconds. This makes it clear at the call site that the argument represents a duration.retry_asyncusetokio::time::sleepinstead of the blockingstd::thread::sleep. Async functions shouldn't block for an extended period of time.