Skip to content

leaflet 1.0 notes #27

Description

@skorasaurus

Hi,

Not sure when you plan to migrate to leaflet 1.0 but I was curious and wanted to try it out.
I was able to get bootleaf your master up and running with leaflet 1.0.0-beta1.

I locally used the master build on the leaflet website which at the time of my download was also the 1.0.0-beta1 release

After modifying my local paths to use the local leaflet, I had this error from markercluster when opening index.html

After building markercluster at this commit from the leaflet-master branch, I added it to my local instance of bootleaf and played around with it and didn't see any abnormal behaviors; clustering markers, filtering locations, etc.

If you want to examine it locally, just follow the above directions or clone https://github.com/skorasaurus/bootleaf/tree/leaflet1

Activity

bmcbride commented on Jul 15, 2015

@bmcbride
Owner

Awesome! Thanks for working on this. I'm hoping take some time after Leaflet 1.0 is released to bring BootLeaf up to snuff, so this will likely save me lots of time and effort. I'll give you a shout if I run into any issues and thanks again!

skorasaurus commented on Oct 27, 2016

@skorasaurus
Author

Hi @bmcbride

I was about to implement leaflet 1.0 on my bootleaf-based fork map and first tested it with your code in master.

To our delight, bootleaf runs on leaflet 1.0 as expected without any significant changes 🎉

I only changes I made from your upstream master:

Mapbox hasn't updated their marker-cluster.js plugin yet, so I used the 1.0.0 release of markercluster from here of it and replaced it locally.

I updated the leaflet urls to point to the new releases.

My code is on https://github.com/skorasaurus/bootleaf/commits/leaflet1
if you want to run it locally.

sabas commented on Nov 12, 2016

@sabas

I confirm it works! Thanks @skorasaurus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions