Fix filter-bar regressions in calendar view and external feeds [#251] - #317
Merged
Merged
Conversation
- Preserve the navigated month when a filter is selected in calendar view. CalendarView's month is now controlled by EventList's calendarDate (which survives filter changes), and the list-level loading/error/empty early returns no longer fire in calendar view, so the calendar is not unmounted-and-reset to today on each toggle. - Auto-close the facet dropdown after a value is selected so long Service Body / Category lists stop covering the first calendar days; also trim the panel max-height. - Re-enforce the event_type filter locally on external-feed events (mirrors the existing category enforcement). A remote on an older Mayo or a non-Mayo feed may ignore the forwarded param and return every type, so filtering on Service now actually hides Activity events from external feeds. Adds unit tests for the matcher. 🐦⬛ Generated with Claude Code, orchestrated by Crow Co-Authored-By: Claude <noreply@anthropic.com> Crow-Session: DA55342E-3D9A-4EB7-B980-B360EDA30629
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #251
Follow-up bug-fix pass on the display filters reported after the 1.9.0 feature shipped.
Fixes
1. Selecting a filter reset the calendar to the current month.
The
activeFilterseffect clearseventsand flipsloading, which tripped the list-levelloading && !events.lengthearly return and unmountedCalendarView— remounting reset its internal month state back to today. Now:CalendarView's displayed month is controlled byEventList'scalendarDate(which is preserved across filter changes), so even a remount shows the navigated month.calendarEvents/calendarLoading), so the calendar stays mounted and just shows its loading overlay while events refetch.2. Filter dropdown didn't auto-close on selection.
Toggling a value now closes the panel, so it stops covering the calendar. Combined with a slightly reduced panel
max-height, this addresses long Service Body / Category lists covering the first days of the calendar.3. External feeds ignored the Event Type filter.
Only
categorieswas re-applied locally on external events;event_typewas forwarded but a remote on an older Mayo (before event_type filtering existed) or a non-Mayo feed ignores it and returns every type. Added local re-enforcement ofevent_type(mirroring the existingcategoriesblock,#292), so filtering on Service actually hides Activity events from external feeds. Empty filter = no constraint.Testing
composer test— 550 tests pass (added 6 unit tests for theevent_typematcher: include/exclude/mixed/empty).npm run build— bundles compile.