Handle labeled previous statements in cuddle checks to avoid false positives on if - #277
Merged
Merged
Conversation
Co-authored-by: bombsimon <3248948+bombsimon@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix false-positive reports for labeled statements
Handle labeled previous statements in cuddle checks to avoid false positives on Aug 8, 2026
if
bombsimon
requested changes
Aug 8, 2026
Co-authored-by: bombsimon <3248948+bombsimon@users.noreply.github.com>
bombsimon
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wslcould incorrectly reportmissing whitespace above this line (invalid statement above if)when aniffollowed a labeled statement, even when the labeled statement wrapped a valid assignment. The check was evaluating*ast.LabeledStmtdirectly instead of the underlying statement kind.Parser logic: unwrap labeled statements before validation
unlabeledStmt(ast.Node) ast.Nodeto peel nested*ast.LabeledStmtwrappers.Behavioral coverage: labeled assignment above
ifdefault_config/iffor a loop label followed byerr := ...andif err != nil, asserting no false-positive whitespace diagnostic.