feat: support passing a coverage parameter to project#422
Open
henryiii wants to merge 2 commits into
Open
Conversation
This would be useful for boost-histogram, as we could support `flow=False` there directly with this. This uses the existing coverage tag, allowing it to be passed in. Assisted-by: Copilot:Kimi-K2.6 Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Contributor
Author
|
@HDembinski how does this look? |
Collaborator
|
project is wrong when you don't have flow bins. Using project without full coverage of flow bins gives wrong results. What's the use case for that? That's why it is intentionally not possible with the API. Scott Meyers: "Make interfaces easy to use correctly and hard or impossible to use incorrectly." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would be useful for boost-histogram, as we could support
flow=Falsethere directly with this. This uses the existing coverage tag, allowing it to be passed in.🤖 Assisted-by: Copilot:Kimi-K2.6 (an open-source model)