Repository navigation
ci: add pull request checks - #427
Open
khanavi272-spec wants to merge 1 commit into
Open
khanavi272-spec wants to merge 1 commit into
khanavi272-spec wants to merge 1 commit into
Conversation
|
@khanavi272-spec is attempting to deploy a commit to the Threadflow Team on Vercel. A member of the Team first needs to authorize it. |
|
@khanavi272-spec Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a GitHub Actions CI workflow to automatically validate every pull request and every push to
main.Previously, the repository did not have a
.github/workflowsconfiguration, so contributors and reviewers had to rely on the Vercel preview or run the project's checks manually. This made it easier for linting, type errors, build failures, or SEO issues to reach the review stage unnoticed.This change introduces a single CI workflow that runs the required checks in a fixed order and stops immediately when a check fails.
Changes
.github/workflows/ci.ymlmainactions/setup-nodenpm cifor clean dependency installationnpm run lintnpx tsc --noEmitnpm run buildnpm run seo:checkNEXT_PUBLIC_*environment variables from.env.exampleCONTRIBUTING.mdCI Execution Order
The workflow intentionally runs the checks in the following order:
npm ciEach check is represented as its own GitHub Actions step, making failures easier to identify and debug.
The workflow also stops at the first failed step so that the reported failure points to the earliest underlying problem rather than a secondary error.
Environment Configuration
The production build uses the public environment variables defined in
.env.example:NEXT_PUBLIC_API_URLNEXT_PUBLIC_SITE_URLNEXT_PUBLIC_BOUNDLESS_APP_URLThese values are provided directly to the workflow because they are public configuration values and do not require GitHub secrets.
Documentation
CONTRIBUTING.mdnow includes a CI section explaining that pull requests are automatically checked for:A pull request is expected to have a green CI run before it is ready for review.
Verification
The workflow has been structured to match the project's existing npm scripts and the requirements described in issue #405.
Related Issue
Closes #405