Repository navigation
fix(tasks): order readout probabilities by the task's labels - #212
Merged
Merged
Conversation
behavior:choice followed Choice.labels but behavior:probabilities followed the readout classifier's own label order, so the two assemblies' .values disagreed column for column.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With a readout,
behavior:choicelisted its columns in the task's label order (Choice(['animal', 'vehicle'])), butbehavior:probabilitieslisted them in the readout classifier's own order (herevehicle, animal). The coordinates were right, so.sel(choice='animal')worked, but.valuesof the two assemblies disagreed column for column. A rebuilt lesson computed p(correct) = 0.21 at 83% accuracy because of it.Fix
Readout probabilities are reordered to
Choice.labels, on both the readout path and next to a generated answer. Likelihood probabilities already followed the labels.Tests
test_readout_probabilities_follow_the_task_label_order, for both label orders. The reversed order fails without the fix.conda_score.sh), unrelated.