Repository navigation
feat: matched random control, quieter readout, safe plugin installs - #213
Merged
Merged
Conversation
The argument is still honoured below sklearn 1.8 and dropping it would move binary probabilities; environment_check guards the version, so the notice was noise on every fit. Claude-Session: https://claude.ai/code/session_01WU1w1HjLtiEMf1v2LHdoKs
Installing a plugin's requirements no longer moves numpy, torch, transformers or the other shared pins; a conflicting plugin raises PluginDependencyError naming the conflict and how to give it its own environment. Python's own module names (imp, collections) in requirements files are skipped. Claude-Session: https://claude.ai/code/session_01WU1w1HjLtiEMf1v2LHdoKs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes from a new user's review of UMI v2.
RandomSelection.matched_to(selection, seed=0): the matched random control in one call. It copies the layer, unit count, population and layout from a resolved functional selection.multi_classdeprecation notice is silenced at fit only. The argument is still honoured below 1.8, and dropping it would move binary probabilities;environment_checkalready guards the version.PluginDependencyErrornaming the conflict ("the plugin asks for transformers==4.30.2; this environment holds transformers==4.57.6") and how to give it its own environment. Packages with no build for the platform, or that fail to build, get their own message.imp,collections) are skipped. They made 16 vision models (BiT-S, mobilenet_v2_*, vonegrcnn) fail to install anywhere.newenvmode, the plugin may still set any versions it needs.Dry-run of all 630 vision and language plugins against the pinned environment:
lm1b: numpy 2). These are now refused with the message above.cv_18_dagger_408_pretrained) and still installs.Note: the existing
newenvrunner (conda_score.sh) cannot work on v2 today. It installs vision into a fresh environment, and vision pinsbrainscore-core==2.4.0rc1, which is not on PyPI. The conflict message therefore suggests cloning the environment instead.CI runs unified at KartikP/brainscore-unified
feat/newuser-ergonomics, whose dependency test checks the new install command.Tests: core suite passes locally, except tests that need conda on PATH or a checkout path without spaces (they fail the same way on base).
https://claude.ai/code/session_01WU1w1HjLtiEMf1v2LHdoKs